yujunjun/haystack
1
0
Fork 0
mirror of https://github.com/deepset-ai/haystack.git synced 2025-09-25 08:04:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix behavior of delete_documents() with filters for Milvus (#1354)

Browse Source 
* Fix behavior of delete_documents()

Delete filtered set of vectors rather than the whole collection

* Update milvus.py

* Update milvus.py
This commit is contained in:
cambiumproject 2021-08-30 08:22:53 -05:00 committed by GitHub
parent 51f0a56e5d
commit 4ca97dd5be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
haystack/document_store/milvus.py
View File

@ -403,9 +403,13 @@ class MilvusDocumentStore(SQLDocumentStore):
if status.code != Status.SUCCESS: if status.code != Status.SUCCESS:
raise RuntimeError(f'Milvus has collection check failed: {status}') raise RuntimeError(f'Milvus has collection check failed: {status}')
if ok: if ok:
status = self.milvus_server.drop_collection(collection_name=index) if filters:
if status.code != Status.SUCCESS: existing_docs = super().get_all_documents(filters=filters, index=index)
raise RuntimeError(f'Milvus drop collection failed: {status}') self._delete_vector_ids_from_milvus(documents=existing_docs, index=index)
else:
status = self.milvus_server.drop_collection(collection_name=index)
if status.code != Status.SUCCESS:
raise RuntimeError(f'Milvus drop collection failed: {status}')
self.milvus_server.flush([index]) self.milvus_server.flush([index])
self.milvus_server.compact(collection_name=index) self.milvus_server.compact(collection_name=index)