chore: fix Windows CI (#3222)

* replicate issue

* pin openjdk version

* not sure it's needed
This commit is contained in:
Massimiliano Pippi 2022-09-16 13:08:30 +02:00 committed by GitHub
parent 42c963f54b
commit 4ddeb7b14b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -251,44 +251,41 @@ jobs:
channel: '#haystack' channel: '#haystack'
if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main' if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
# FIXME Disabled due to #3219 elasticsearch-tests-windows:
# elasticsearch-tests-windows: needs:
# needs: - mypy
# - mypy - pylint
# - pylint runs-on: windows-latest
# runs-on: windows-latest if: contains(github.event.pull_request.labels.*.name, 'topic:windows') || !github.event.pull_request.draft
# if: contains(github.event.pull_request.labels.*.name, 'topic:windows') || !github.event.pull_request.draft
# steps: steps:
# - uses: actions/checkout@v2 - uses: actions/checkout@v2
# - name: Set up Elasticsearch and pdftotext - name: Install dependencies
# run: | run: |
# choco install xpdf-utils choco install --no-progress xpdf-utils
# choco install openjdk11 choco install --no-progress openjdk --version=11.0.2.01
# refreshenv refreshenv
# choco install elasticsearch --version=7.9.2 choco install --no-progress elasticsearch --version=7.9.2
# refreshenv refreshenv
# Get-Service elasticsearch-service-x64 | Start-Service Get-Service elasticsearch-service-x64 | Start-Service
# - name: Install Haystack
# run: pip install .
# - name: Setup Python - name: Setup Python
# uses: ./.github/actions/python_cache/ uses: ./.github/actions/python_cache/
# with: with:
# prefix: windows prefix: windows
# - name: Run tests - name: Run tests
# env: env:
# TOKENIZERS_PARALLELISM: 'false' TOKENIZERS_PARALLELISM: 'false'
# run: | run: |
# pytest ${{ env.PYTEST_PARAMS }} -m "elasticsearch and not integration" test/document_stores/ ${{ env.SUITES_EXCLUDED_FROM_WINDOWS }} --document_store_type=elasticsearch pytest ${{ env.PYTEST_PARAMS }} -m "elasticsearch and not integration" test/document_stores/ ${{ env.SUITES_EXCLUDED_FROM_WINDOWS }} --document_store_type=elasticsearch
# - uses: act10ns/slack@v1 - uses: act10ns/slack@v1
# with: with:
# status: ${{ job.status }} status: ${{ job.status }}
# channel: '#haystack' channel: '#haystack'
# if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main' if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
faiss-tests-linux: faiss-tests-linux:
needs: needs:
@ -712,54 +709,53 @@ jobs:
channel: '#haystack' channel: '#haystack'
if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main' if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
# FIXME Disabled due to #3219 integration-tests-windows:
# integration-tests-windows: needs:
# needs: - unit-tests-windows
# - unit-tests-windows - elasticsearch-tests-windows
# - elasticsearch-tests-windows runs-on: windows-latest
# runs-on: windows-latest if: contains(github.event.pull_request.labels.*.name, 'topic:windows') || !github.event.pull_request.draft
# if: contains(github.event.pull_request.labels.*.name, 'topic:windows') || !github.event.pull_request.draft
# timeout-minutes: 30 timeout-minutes: 30
# strategy: strategy:
# fail-fast: false # Avoid cancelling the others if one of these fails fail-fast: false # Avoid cancelling the others if one of these fails
# matrix: matrix:
# folder: folder:
# - "nodes" - "nodes"
# - "pipelines" - "pipelines"
# - "modeling" - "modeling"
# - "others" - "others"
# steps: steps:
# - uses: actions/checkout@v2 - uses: actions/checkout@v2
# - name: Set up Elasticsearch and pdftotext - name: Install dependencies
# run: | run: |
# choco install xpdf-utils choco install --no-progress xpdf-utils
# choco install openjdk11 choco install --no-progress tesseract
# refreshenv choco install --no-progress openjdk --version=11.0.2.01
# choco install tesseract --pre refreshenv
# choco install elasticsearch --version=7.9.2 choco install --no-progress elasticsearch --version=7.9.2
# refreshenv refreshenv
# Get-Service elasticsearch-service-x64 | Start-Service Get-Service elasticsearch-service-x64 | Start-Service
# - name: Setup Python - name: Setup Python
# uses: ./.github/actions/python_cache/ uses: ./.github/actions/python_cache/
# with: with:
# prefix: windows prefix: windows
# - name: Install Haystack - name: Install Haystack
# run: pip install . run: pip install .
# - name: Run tests - name: Run tests
# env: env:
# TOKENIZERS_PARALLELISM: 'false' # Avoid logspam by tokenizers TOKENIZERS_PARALLELISM: 'false' # Avoid logspam by tokenizers
# # FIXME many tests are disabled here! # FIXME many tests are disabled here!
# run: | run: |
# pytest ${{ env.PYTEST_PARAMS }} -m "integration and not tika and not graphdb" ${{ env.SUITES_EXCLUDED_FROM_WINDOWS }} test/${{ matrix.folder }} --document_store_type=memory,faiss,elasticsearch pytest ${{ env.PYTEST_PARAMS }} -m "integration and not tika and not graphdb" ${{ env.SUITES_EXCLUDED_FROM_WINDOWS }} test/${{ matrix.folder }} --document_store_type=memory,faiss,elasticsearch
# - uses: act10ns/slack@v1 - uses: act10ns/slack@v1
# with: with:
# status: ${{ job.status }} status: ${{ job.status }}
# channel: '#haystack' channel: '#haystack'
# if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main' if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'