yujunjun/haystack
1
0
Fork 0
mirror of https://github.com/deepset-ai/haystack.git synced 2025-12-27 15:08:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Increase all_close tolerance for milvus2, improve assertion infos (#2375)

Browse Source
This commit is contained in:
tstadel 2022-03-31 11:41:13 +02:00 committed by GitHub
parent a273c3a51d
commit 5b52690c5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/test_faiss_and_milvus.py
View File

@ -485,7 +485,6 @@ def test_faiss_passing_index_from_outside(tmp_path):
@pytest.mark.parametrize("document_store", ["faiss", "milvus1", "milvus", "weaviate"], indirect=True)
def test_cosine_similarity(document_store):
# below we will write documents to the store and then query it to see if vectors were normalized
ensure_ids_are_correct_uuids(docs=DOCUMENTS, document_store=document_store)
document_store.write_documents(documents=DOCUMENTS)
@ -506,7 +505,9 @@ def test_cosine_similarity(document_store):
original_emb = indexed_docs[doc.content].astype("float32")
# check if the stored embedding was normalized
assert np.allclose(original_emb, result_emb, rtol=0.2) # high tolerance necessary for Milvus 2
np.testing.assert_allclose(
original_emb, result_emb, rtol=0.2, atol=5e-07
) # high tolerance necessary for Milvus 2
# check if the score is plausible for cosine similarity
assert 0 <= doc.score <= 1.0