yujunjun/haystack
1
0
Fork 0
mirror of https://github.com/deepset-ai/haystack.git synced 2025-10-16 10:28:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

bug: mypy should ignore files in test/ (#3894)

Browse Source 
* exclude files in test/

* verify that the CI ignores test files

* dont fail in case of no files
This commit is contained in:
ZanSara 2023-01-19 18:12:26 +01:00 committed by GitHub
parent 4c28253955
commit 90c877a559
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.github/workflows/tests.yml vendored
View File

@ -93,7 +93,9 @@ jobs:
run: | run: |
for file in ${{ steps.files.outputs.all_changed_files }}; do for file in ${{ steps.files.outputs.all_changed_files }}; do
if [[ $file == *.py ]]; then if [[ $file == *.py ]]; then
changed_files="$changed_files $file" if [[ $file != test/* ]]; then
changed_files="$changed_files $file"
fi
fi fi
done done
echo "changed_files=$changed_files" >> $GITHUB_OUTPUT echo "changed_files=$changed_files" >> $GITHUB_OUTPUT
@ -104,6 +106,7 @@ jobs:
pythonVersion: 3.8 # Literals and mypy just don't work well together. pythonVersion: 3.8 # Literals and mypy just don't work well together.
- name: Mypy - name: Mypy
if: steps.python-files.outputs.changed_files
run: | run: |
mkdir .mypy_cache/ mkdir .mypy_cache/
mypy ${{ steps.python-files.outputs.changed_files }} mypy ${{ steps.python-files.outputs.changed_files }}

1
test/conftest.py
View File

@ -35,7 +35,6 @@ from haystack.document_stores import (
OpenSearchDocumentStore, OpenSearchDocumentStore,
GraphDBKnowledgeGraph, GraphDBKnowledgeGraph,
FAISSDocumentStore, FAISSDocumentStore,
SQLDocumentStore,
) )
from haystack.nodes import ( from haystack.nodes import (
BaseReader, BaseReader,