From 9d8979af41421b53b8d2ec3a006bf48f57a70357 Mon Sep 17 00:00:00 2001
From: Shaurya Agrawal <79003829+shag1802@users.noreply.github.com>
Date: Mon, 23 Oct 2023 17:32:35 +0530
Subject: [PATCH] feat: Refactor SentenceTransformersDocumentEmbedder.py
 (#6143)

* changed sentense_transformers

* added release note

* updated release notes

* Corrected release notes

---------

Co-authored-by: Stefano Fiorucci <44616784+anakin87@users.noreply.github.com>
---
 .../embedders/sentence_transformers_document_embedder.py   | 7 ++-----
 ...se-transformers-document-embedder-f4ed8d10aaccd08c.yaml | 4 ++++
 2 files changed, 6 insertions(+), 5 deletions(-)
 create mode 100644 releasenotes/notes/refactor-sentense-transformers-document-embedder-f4ed8d10aaccd08c.yaml

diff --git a/haystack/preview/components/embedders/sentence_transformers_document_embedder.py b/haystack/preview/components/embedders/sentence_transformers_document_embedder.py
index 821730ab2..8986c2769 100644
--- a/haystack/preview/components/embedders/sentence_transformers_document_embedder.py
+++ b/haystack/preview/components/embedders/sentence_transformers_document_embedder.py
@@ -125,10 +125,7 @@ class SentenceTransformersDocumentEmbedder:
             normalize_embeddings=self.normalize_embeddings,
         )
 
-        documents_with_embeddings = []
         for doc, emb in zip(documents, embeddings):
-            doc_as_dict = doc.to_dict()
-            doc_as_dict["embedding"] = emb
-            documents_with_embeddings.append(Document.from_dict(doc_as_dict))
+            doc.embedding = emb
 
-        return {"documents": documents_with_embeddings}
+        return {"documents": documents}
diff --git a/releasenotes/notes/refactor-sentense-transformers-document-embedder-f4ed8d10aaccd08c.yaml b/releasenotes/notes/refactor-sentense-transformers-document-embedder-f4ed8d10aaccd08c.yaml
new file mode 100644
index 000000000..325a7f895
--- /dev/null
+++ b/releasenotes/notes/refactor-sentense-transformers-document-embedder-f4ed8d10aaccd08c.yaml
@@ -0,0 +1,4 @@
+---
+preview:
+  - |
+    Refactor SentenceTransformersDocumentEmbedder to enrich documents with embeddings instead of recreating them.