From c8df4763f838836ad84380078093c4c99b98e882 Mon Sep 17 00:00:00 2001 From: Julian Risch Date: Mon, 1 Nov 2021 10:39:13 +0100 Subject: [PATCH] disable file upload for InMemoryDocStore (#1677) --- rest_api/controller/file_upload.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/rest_api/controller/file_upload.py b/rest_api/controller/file_upload.py index d3d34a209..5dff2dbb0 100644 --- a/rest_api/controller/file_upload.py +++ b/rest_api/controller/file_upload.py @@ -21,14 +21,15 @@ try: path=Path(PIPELINE_YAML_PATH), pipeline_name=INDEXING_PIPELINE_NAME, overwrite_with_env_variables=True ) # Since each instance of FAISSDocumentStore creates an in-memory FAISS index, the Indexing & Query Pipelines would - # end up with different indices. The check below prevents creation of Indexing Pipelines with FAISSDocumentStore. - is_faiss_present = False + # end up with different indices. The same applies for InMemoryDocumentStore. The check below prevents creation of + # Indexing Pipelines with FAISSDocumentStore or InMemoryDocumentStore. + is_faiss_or_inmemory_present = False for node in pipeline_config["nodes"]: - if definitions[node["name"]]["type"] == "FAISSDocumentStore": - is_faiss_present = True + if definitions[node["name"]]["type"] == "FAISSDocumentStore" or definitions[node["name"]]["type"] == "InMemoryDocumentStore": + is_faiss_or_inmemory_present = True break - if is_faiss_present: - logger.warning("Indexing Pipeline with FAISSDocumentStore is not supported with the REST APIs.") + if is_faiss_or_inmemory_present: + logger.warning("Indexing Pipeline with FAISSDocumentStore or InMemoryDocumentStore is not supported with the REST APIs.") INDEXING_PIPELINE = None else: INDEXING_PIPELINE = Pipeline.load_from_yaml(Path(PIPELINE_YAML_PATH), pipeline_name=INDEXING_PIPELINE_NAME)