From ec3558021e0a5a007c53cd60b9d6a7997bc937a1 Mon Sep 17 00:00:00 2001 From: Silvano Cerza <3314350+silvanocerza@users.noreply.github.com> Date: Tue, 21 Nov 2023 15:08:16 +0100 Subject: [PATCH] Remove Document Store tests with invalid filter (#6375) --- haystack/preview/testing/document_store.py | 24 ---------------------- 1 file changed, 24 deletions(-) diff --git a/haystack/preview/testing/document_store.py b/haystack/preview/testing/document_store.py index 61bc18e00..04b0541e5 100644 --- a/haystack/preview/testing/document_store.py +++ b/haystack/preview/testing/document_store.py @@ -673,14 +673,6 @@ class LegacyFilterDocumentsSimpleLogicalTest(FilterableDocsFixtureMixin): if "number" in doc.meta and doc.meta["number"] >= 0.0 and doc.meta["number"] <= 2.0 ] - @pytest.mark.unit - def test_filter_simple_explicit_and_with_multikey_dict( - self, document_store: DocumentStore, filterable_docs: List[Document] - ): - document_store.write_documents(filterable_docs) - result = document_store.filter_documents(filters={"number": {"$and": {"$gte": 0, "$lte": 2}}}) - assert result == [doc for doc in filterable_docs if "number" in doc.meta and 0 <= doc.meta["number"] <= 2] - @pytest.mark.unit def test_filter_simple_explicit_and_with_list(self, document_store: DocumentStore, filterable_docs: List[Document]): document_store.write_documents(filterable_docs) @@ -717,22 +709,6 @@ class LegacyFilterDocumentsNestedLogicalTest(FilterableDocsFixtureMixin): ``` """ - @pytest.mark.unit - def test_filter_nested_explicit_and(self, document_store: DocumentStore, filterable_docs: List[Document]): - document_store.write_documents(filterable_docs) - filters = {"$and": {"number": {"$and": {"$lte": 2, "$gte": 0}}, "name": {"$in": ["name_0", "name_1"]}}} - result = document_store.filter_documents(filters=filters) - assert result == [ - doc - for doc in filterable_docs - if ( - "number" in doc.meta - and doc.meta["number"] >= 0 - and doc.meta["number"] <= 2 - and doc.meta["name"] in ["name_0", "name_1"] - ) - ] - @pytest.mark.unit def test_filter_nested_implicit_and(self, document_store: DocumentStore, filterable_docs: List[Document]): document_store.write_documents(filterable_docs)