From ecce6f658fa4563df0935ffca9257762825c8367 Mon Sep 17 00:00:00 2001 From: "David S. Batista" Date: Wed, 3 Dec 2025 17:07:30 +0100 Subject: [PATCH] chore: small improvements SentenceWindowRetriever --- .../retrievers/sentence_window_retriever.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/haystack/components/retrievers/sentence_window_retriever.py b/haystack/components/retrievers/sentence_window_retriever.py index 74449d836..b3760658f 100644 --- a/haystack/components/retrievers/sentence_window_retriever.py +++ b/haystack/components/retrievers/sentence_window_retriever.py @@ -204,7 +204,7 @@ class SentenceWindowRetriever: """ window_size = window_size or self.window_size - self._raise_if_windows_size_is_negative(window_size) + SentenceWindowRetriever._raise_if_windows_size_is_negative(window_size) self._raise_if_documents_do_not_have_expected_metadata(retrieved_documents) context_text = [] @@ -237,7 +237,7 @@ class SentenceWindowRetriever: """ window_size = window_size or self.window_size - self._raise_if_windows_size_is_negative(window_size) + SentenceWindowRetriever._raise_if_windows_size_is_negative(window_size) self._raise_if_documents_do_not_have_expected_metadata(retrieved_documents) context_text = [] @@ -249,7 +249,8 @@ class SentenceWindowRetriever: return {"context_windows": context_text, "context_documents": context_documents} - def _raise_if_windows_size_is_negative(self, window_size: int) -> None: + @staticmethod + def _raise_if_windows_size_is_negative(window_size: int) -> None: if window_size < 1: raise ValueError("The window_size parameter must be greater than 0.") @@ -278,7 +279,7 @@ class SentenceWindowRetriever: source_id=self._source_id_meta_fields, split_id=self.split_id_meta_field, ) - return (doc.content or "", [doc]) + return doc.content or "", [doc] assert split_id is not None filter_conditions = self._build_filter_conditions(split_id, window_size, source_ids) @@ -300,7 +301,7 @@ class SentenceWindowRetriever: source_id=self._source_id_meta_fields, split_id=self.split_id_meta_field, ) - return (doc.content or "", [doc]) + return doc.content or "", [doc] assert split_id is not None filter_conditions = self._build_filter_conditions(split_id, window_size, source_ids)