From fb5db59590757303d16dfc6d2bd0d837446c6fae Mon Sep 17 00:00:00 2001 From: Guillim Date: Tue, 22 Sep 2020 09:01:04 +0200 Subject: [PATCH] Remove useless line from Tutorial4_FAQ_style_QA (#416) * Update Tutorial4_FAQ_style_QA.py Used to be useful when `.apply()` was necessary, but not any longer * Update Tutorial4_FAQ_style_QA.ipynb --- tutorials/Tutorial4_FAQ_style_QA.ipynb | 3 +-- tutorials/Tutorial4_FAQ_style_QA.py | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/tutorials/Tutorial4_FAQ_style_QA.ipynb b/tutorials/Tutorial4_FAQ_style_QA.ipynb index 3916c960d..6cfcce293 100644 --- a/tutorials/Tutorial4_FAQ_style_QA.ipynb +++ b/tutorials/Tutorial4_FAQ_style_QA.ipynb @@ -189,7 +189,6 @@ "# Get embeddings for our questions from the FAQs\n", "questions = list(df[\"question\"].values)\n", "df[\"question_emb\"] = retriever.embed_queries(texts=questions)\n", - "df[\"question_emb\"] = df[\"question_emb\"]\n", "df = df.rename(columns={\"answer\": \"text\"})\n", "\n", "# Convert Dataframe to list of dicts and index them in our DocumentStore\n", @@ -251,4 +250,4 @@ }, "nbformat": 4, "nbformat_minor": 2 -} \ No newline at end of file +} diff --git a/tutorials/Tutorial4_FAQ_style_QA.py b/tutorials/Tutorial4_FAQ_style_QA.py index 0d0a7c1c8..cc371db3b 100755 --- a/tutorials/Tutorial4_FAQ_style_QA.py +++ b/tutorials/Tutorial4_FAQ_style_QA.py @@ -67,7 +67,6 @@ print(df.head()) # Get embeddings for our questions from the FAQs questions = list(df["question"].values) df["question_emb"] = retriever.embed_queries(texts=questions) -df["question_emb"] = df["question_emb"] df = df.rename(columns={"answer": "text"}) # Convert Dataframe to list of dicts and index them in our DocumentStore