yujunjun/haystack
1
0
Fork 0
mirror of https://github.com/deepset-ai/haystack.git synced 2025-11-04 11:49:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: revert Weaviate query with filters and improve tests (#3646)

Browse Source 
* revert weaviate query with filters and improve tests

* pylint

* upgrade weaviate container

* use latest docker tag

* fix text

* fix text
This commit is contained in:
Sara Zan 2022-12-06 14:48:58 +01:00 committed by GitHub
parent e4c3817d01
commit fc89f6ea74
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/tests.yml vendored
View File

@ -335,7 +335,7 @@ jobs:
runs-on: ${{ matrix.os }}
services:
weaviate:
image: semitechnologies/weaviate:1.16.0
image: semitechnologies/weaviate:latest
env:
AUTHENTICATION_ANONYMOUS_ACCESS_ENABLED: "true"
PERSISTENCE_DATA_PATH: "/var/lib/weaviate"

34
haystack/document_stores/weaviate.py
View File

@ -985,28 +985,30 @@ class WeaviateDocumentStore(BaseDocumentStore):
)
# Retrieval with BM25 AND filtering
if filters:
# Once Weaviate starts supporting filters with BM25:
filter_dict = LogicalFilterClause.parse(filters).convert_to_weaviate()
if filters: # pylint: disable=no-else-raise
raise NotImplementedError(
"Weaviate currently does not support filters WITH inverted index text query (eg BM25)!"
)
# # Once Weaviate starts supporting filters with BM25:
# filter_dict = LogicalFilterClause.parse(filters).convert_to_weaviate()
# gql_query = (
# weaviate.gql.get.GetBuilder(
# class_name=index, properties=properties, connection=self.weaviate_client
# )
# .with_near_vector({"vector": [0, 0]})
# .with_where(filter_dict)
# .with_limit(top_k)
# .build()
# )
else:
# BM25 retrieval without filtering
gql_query = (
weaviate.gql.get.GetBuilder(
class_name=index, properties=properties, connection=self.weaviate_client
)
gql.get.GetBuilder(class_name=index, properties=properties, connection=self.weaviate_client)
.with_near_vector({"vector": [0, 0]})
.with_where(filter_dict)
.with_limit(top_k)
.build()
)
# BM25 retrieval without filtering
gql_query = (
gql.get.GetBuilder(class_name=index, properties=properties, connection=self.weaviate_client)
.with_near_vector({"vector": [0, 0]})
.with_limit(top_k)
.build()
)
# Build the BM25 part of the GQL manually.
# Currently the GetBuilder of the Weaviate-client (v3.6.0)
# does not support the BM25 part of GQL building, so

5
test/document_stores/test_weaviate.py
View File

@ -180,8 +180,9 @@ class TestWeaviateDocumentStore(DocumentStoreBaseTestAbstract):
assert len(docs) == 3
# BM25 retrieval WITH filters is not yet supported as of Weaviate v1.14.1
# with pytest.raises(Exception):
docs = ds.query(query_text, filters={"name": ["filename2"]})
# Should be from 1.18: https://github.com/semi-technologies/weaviate/issues/2393
# docs = ds.query(query_text, filters={"name": ["name_1"]})
# assert len(docs) == 1
docs = ds.query(filters={"name": ["name_0"]})
assert len(docs) == 3