yujunjun/haystack
1
0
Fork 0
mirror of https://github.com/deepset-ai/haystack.git synced 2025-12-14 00:25:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: huggingface embedder error messages not being displayed (#8537)

Browse Source 
* initial import

* fixing too-many-arguments - since file is now changed pylint checks it

* more fixes

* disable too-arguments pylint
This commit is contained in:
David S. Batista 2024-11-12 14:59:20 +01:00 committed by GitHub
parent 852900d5e3
commit fcdf392bfb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
haystack/components/embedders/hugging_face_api_document_embedder.py
View File

@ -102,7 +102,7 @@ class HuggingFaceAPIDocumentEmbedder:
progress_bar: bool = True, progress_bar: bool = True,
meta_fields_to_embed: Optional[List[str]] = None, meta_fields_to_embed: Optional[List[str]] = None,
embedding_separator: str = "\n", embedding_separator: str = "\n",
): ): # pylint: disable=too-many-positional-arguments
""" """
Creates a HuggingFaceAPIDocumentEmbedder component. Creates a HuggingFaceAPIDocumentEmbedder component.
@ -168,7 +168,7 @@ class HuggingFaceAPIDocumentEmbedder:
model_or_url = url model_or_url = url
else: else:
msg = f"Unknown api_type {api_type}" msg = f"Unknown api_type {api_type}"
raise ValueError(api_type) raise ValueError(msg)
self.api_type = api_type self.api_type = api_type
self.api_params = api_params self.api_params = api_params

4
haystack/components/embedders/hugging_face_api_text_embedder.py
View File

@ -82,7 +82,7 @@ class HuggingFaceAPITextEmbedder:
suffix: str = "", suffix: str = "",
truncate: bool = True, truncate: bool = True,
normalize: bool = False, normalize: bool = False,
): ): # pylint: disable=too-many-positional-arguments
""" """
Creates a HuggingFaceAPITextEmbedder component. Creates a HuggingFaceAPITextEmbedder component.
@ -138,7 +138,7 @@ class HuggingFaceAPITextEmbedder:
model_or_url = url model_or_url = url
else: else:
msg = f"Unknown api_type {api_type}" msg = f"Unknown api_type {api_type}"
raise ValueError() raise ValueError(msg)
self.api_type = api_type self.api_type = api_type
self.api_params = api_params self.api_params = api_params

4
haystack/components/generators/chat/hugging_face_api.py
View File

@ -104,7 +104,7 @@ class HuggingFaceAPIChatGenerator:
``` ```
""" """
def __init__( def __init__( # pylint: disable=too-many-positional-arguments
self, self,
api_type: Union[HFGenerationAPIType, str], api_type: Union[HFGenerationAPIType, str],
api_params: Dict[str, str], api_params: Dict[str, str],
@ -162,7 +162,7 @@ class HuggingFaceAPIChatGenerator:
model_or_url = url model_or_url = url
else: else:
msg = f"Unknown api_type {api_type}" msg = f"Unknown api_type {api_type}"
raise ValueError(api_type) raise ValueError(msg)
# handle generation kwargs setup # handle generation kwargs setup
generation_kwargs = generation_kwargs.copy() if generation_kwargs else {} generation_kwargs = generation_kwargs.copy() if generation_kwargs else {}

2
haystack/components/generators/hugging_face_api.py
View File

@ -134,7 +134,7 @@ class HuggingFaceAPIGenerator:
model_or_url = url model_or_url = url
else: else:
msg = f"Unknown api_type {api_type}" msg = f"Unknown api_type {api_type}"
raise ValueError(api_type) raise ValueError(msg)
# handle generation kwargs setup # handle generation kwargs setup
generation_kwargs = generation_kwargs.copy() if generation_kwargs else {} generation_kwargs = generation_kwargs.copy() if generation_kwargs else {}