* workflow to push relnotes to website
* fix workflow
* set default repo
* fix
* correct format for version
* refinements
* try creating PR
* try setting version
* fixes
* clean up
* more clean up
* include components with consumed outputs in pipeline results
* update test
* update test
* release notes
* Add async pipeline test and update more checks in async pipeline
---------
Co-authored-by: Sebastian Husch Lee <sjrl423@gmail.com>
* Fix to dict and json schema support
* Update Azure Responses
* Add tests
* Fix tests
* Fix tests
* remove print
* Change model
* Add a new test
* Loosen tests
* Update information in streaming chunks and fix convert streaming chunks to chat message when handling reasoning content
* Fix unit test
* fix mypy
* try to make integration test more reliable
* Remove unused imports
* Add working ChatGenerator
* rename
* Improve and add live tests
* Updates
* Update the tests
* Fix errors
* Add release notes
* Add support for openai tools
* Remove openai tools test that times out
* fix tool calls
* Update release notes
* PR comments
* remove edits to chat message
* Add a test
* PR comments
* Send back reasoning to model
* Fix reasoning support
* Add reasoning support
* Fix tests
* Refactor
* Simplify methods
* Fix mypy
* Stream responses, tool calls etc
* Update docstrings
* Fix errors while using in Agent
* Fix call_id and fc_id
* Update tests
* Updates
* Add extra in ToolCall and ToolCallDelta
* Update streaming chunk
* Fix tests and linting
* Update api key resolve
* PR comments
* PR comments
* Updates
* some type fixes and also make sure to use flatten_tools_or_toolsets
* fix docs
* Fix streaming chunks so assistant header is properly captured
* Add finish_reason and update test
* Skip streaming + pydantic model test b/c of known issue in openai python sdk https://github.com/openai/openai-python/issues/2305
* Fix pylint
* Initial commit adding AzureOpenAIResponsesChatGenerator support
* fix unit test
* Starting to refactor to use new recommended way to connect to Azure OpenAI
* Updates
* Fix tests
* More tests
* fix integration tests
* Add to docs
* Don't need warm_up method anymore
* fix unit test
* Fix pylint
* fix docstrings
* fix mypy typing
* fix reno
* Add another unit test
---------
Co-authored-by: Amna Mubashar <amnahkhan.ak@gmail.com>
* Add working ChatGenerator
* rename
* Improve and add live tests
* Updates
* Update the tests
* Fix errors
* Add release notes
* Add support for openai tools
* Remove openai tools test that times out
* fix tool calls
* Update release notes
* PR comments
* remove edits to chat message
* Add a test
* PR comments
* Send back reasoning to model
* Fix reasoning support
* Add reasoning support
* Fix tests
* Refactor
* Simplify methods
* Fix mypy
* Stream responses, tool calls etc
* Update docstrings
* Fix errors while using in Agent
* Fix call_id and fc_id
* Update tests
* Updates
* Add extra in ToolCall and ToolCallDelta
* Update streaming chunk
* Fix tests and linting
* Update api key resolve
* PR comments
* PR comments
* Updates
* some type fixes and also make sure to use flatten_tools_or_toolsets
* fix docs
* Fix streaming chunks so assistant header is properly captured
* Add finish_reason and update test
* Skip streaming + pydantic model test b/c of known issue in openai python sdk https://github.com/openai/openai-python/issues/2305
* Fix pylint
---------
Co-authored-by: Sebastian Husch Lee <sjrl423@gmail.com>
* fix: warm up individual tools inside Toolsets in warm_up_tools()
Related Issues:
* Follows up on PR #9942 (feat: Add warm_up() method to ChatGenerators)
* Addresses bug discovered during implementation of PR #9942 for issue #9907
Proposed Changes:
The warm_up_tools() utility function was only calling warm_up() on
Toolset objects themselves, but not on the individual Tool instances
contained within them. This meant tools inside a Toolset were not
properly initialized before use.
This PR modifies warm_up_tools() to iterate through Toolsets and call
warm_up() on each individual tool, in addition to calling warm_up() on
the Toolset itself.
Changes:
- Modified warm_up_tools() in haystack/tools/utils.py to iterate through
Toolsets when encountered (both as single argument and within lists)
- Added iteration to call warm_up() on each individual Tool inside Toolsets
- Added comprehensive test class TestWarmUpTools with 7 test cases
How did you test it:
- Added 7 comprehensive unit tests in test/tools/test_tools_utils.py:
* test_warm_up_tools_with_none - handles None input
* test_warm_up_tools_with_single_tool - single tool in list
* test_warm_up_tools_with_single_toolset - KEY TEST: verifies both
Toolset and individual tools are warmed
* test_warm_up_tools_with_list_containing_toolset - toolset within list
* test_warm_up_tools_with_multiple_toolsets - multiple toolsets
* test_warm_up_tools_with_mixed_tools_and_toolsets - mixed scenarios
* test_warm_up_tools_idempotency - safe to call multiple times
Notes for the reviewer:
I discovered this bug while implementing PR #9942 (for issue #9907).
When a Toolset object is passed to a component's tools parameter, the
warm_up_tools() function only calls Toolset.warm_up(), which is a no-op.
It doesn't iterate through the individual tools inside the Toolset to
warm them up.
acknowledged by @vblagoje and @sjrl
This implementation:
- Modified warm_up_tools() to iterate through Toolsets and call warm_up() on each individual tool
- Added comprehensive tests for Toolset warming behavior
- Verified both the Toolset and its contained tools are warmed up
Checklist:
I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:
I documented my code
I ran pre-commit hooks and fixed any issue
* added release note
* refactor: move tool warm-up iteration to Toolset.warm_up()
Addresses architectural feedback - moved iteration logic from warm_up_tools()
to base Toolset.warm_up() for better encapsulation. Subclasses can now
override warm_up() to customize initialization without breaking the contract.
- Toolset.warm_up() now iterates and warms tools by default
- warm_up_tools() simplified to delegate to warm_up()
- Updated tests and release notes
---------
Co-authored-by: HamidOna13 <abdulhamid.onawole@aizatron.com>
