mirror of
https://github.com/deepset-ai/haystack.git
synced 2025-09-26 08:33:51 +00:00

* Saves the FAISSDocumentStore init params to JSON at save() and loads them at load() if they're found. First draft, to be tested. * Fixing issue with string/Path objects in a few string operations, thanks mypy * Leverage self.set_config instead of saving the parameters in a separate attribute * Modify test_faiss_and_milvus:test_faiss_index_save_and_load to test that init params are preserved * Add assert to verify that the SQL doc count and FAISS vector count is equal. Needs to always specify the name of the SQL db for this to work * Simplified the implementation a bit, add better comments * Forgot a return at the end of the file * Fixing some of the suggestions from the review * Add a try-catch in the load method and fix the tests * Typo