yujunjun/knex
1
0
Fork 0
mirror of https://github.com/knex/knex.git synced 2025-12-29 07:59:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

New tests showed a flaw in mysql code, fix it

Browse Source
This commit is contained in:
Kris Reeves 2015-02-04 11:03:24 -05:00
parent 1d1c6b9360
commit 617c36cfc7
1 changed files with 71 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
lib/dialects/mysql/schema/table.js
View File

@ -8,6 +8,8 @@ var inherits = require('inherits');
var Schema = require('../../../schema');
var helpers = require('../../../helpers');
var Promise = require('../../../promise');
// Table Builder
// ------
@ -68,20 +70,85 @@ TableCompiler_MySQL.prototype.changeType = function() {
// Renames a column on the table.
TableCompiler_MySQL.prototype.renameColumn = function(from, to) {
var table = this.tableName();
var wrapped = this.formatter.wrap(from) + ' ' + this.formatter.wrap(to);
var compiler = this;
var table = this.tableName();
var wrapped = this.formatter.wrap(from) + ' ' + this.formatter.wrap(to);
this.pushQuery({
sql: 'show fields from ' + table + ' where field = ' +
this.formatter.parameter(from),
output: function(resp) {
var column = resp[0];
return this.query({
sql: 'alter table ' + table + ' change ' + wrapped + ' ' + column.Type
var runner = this;
return compiler.getFKRefs(runner).get(0)
.then(function (refs) {
return Promise.try(function () {
if (!refs.length) { return; }
return compiler.dropFKRefs(runner, refs);
}).then(function () {
return runner.query({
sql: 'alter table ' + table + ' change ' + wrapped + ' ' + column.Type
});
}).then(function () {
if (!refs.length) { return; }
return compiler.createFKRefs(runner, refs.map(function (ref) {
if (ref.REFERENCED_COLUMN_NAME === from) {
ref.REFERENCED_COLUMN_NAME = to;
}
if (ref.COLUMN_NAME === from) {
ref.COLUMN_NAME = to;
}
return ref;
}));
});
});
}
});
};
TableCompiler_MySQL.prototype.getFKRefs = function (runner) {
var formatter = new this.Formatter();
var sql = 'SELECT KCU.CONSTRAINT_NAME, KCU.TABLE_NAME, KCU.COLUMN_NAME, '+
' KCU.REFERENCED_TABLE_NAME, KCU.REFERENCED_COLUMN_NAME, '+
' RC.UPDATE_RULE, RC.DELETE_RULE '+
'FROM INFORMATION_SCHEMA.KEY_COLUMN_USAGE AS KCU '+
'JOIN INFORMATION_SCHEMA.REFERENTIAL_CONSTRAINTS AS RC '+
' USING(CONSTRAINT_NAME)' +
'WHERE KCU.REFERENCED_TABLE_NAME = ' + formatter.parameter(this.tableNameRaw) + ' '+
' AND KCU.CONSTRAINT_SCHEMA = ' + formatter.parameter(this.client.databaseName);
return runner.query({
sql: sql,
bindings: formatter.bindings
});
};
TableCompiler_MySQL.prototype.dropFKRefs = function (runner, refs) {
var formatter = new this.Formatter();
return Promise.all(refs.map(function (ref) {
var constraintName = formatter.wrap(ref.CONSTRAINT_NAME);
return runner.query({
sql: 'alter table ' + this.tableName() + ' drop foreign key ' + constraintName
});
}.bind(this)));
};
TableCompiler_MySQL.prototype.createFKRefs = function (runner, refs) {
var formatter = new this.Formatter();
return Promise.all(refs.map(function (ref) {
var keyName = formatter.wrap(ref.COLUMN_NAME);
var column = formatter.columnize(ref.COLUMN_NAME);
var references = formatter.columnize(ref.REFERENCED_COLUMN_NAME);
var inTable = formatter.wrap(ref.REFERENCED_TABLE_NAME);
var onUpdate = ' ON UPDATE ' + ref.UPDATE_RULE;
var onDelete = ' ON DELETE ' + ref.DELETE_RULE;
return runner.query({
sql: 'alter table ' + this.tableName() + ' add constraint ' + keyName + ' ' +
'foreign key (' + column + ') references ' + inTable + ' (' + references + ')' + onUpdate + onDelete
});
}.bind(this)));
};
TableCompiler_MySQL.prototype.index = function(columns, indexName) {
indexName = indexName || this._indexCommand('index', this.tableNameRaw, columns);
this.pushQuery('alter table ' + this.tableName() + " add index " + indexName + "(" + this.formatter.columnize(columns) + ")");