yujunjun/knex
1
0
Fork 0
mirror of https://github.com/knex/knex.git synced 2025-12-28 15:38:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Fix SQLite not doing rollback when altering columns fails (#4336)" (#4896)

Browse Source
This commit is contained in:
Nicola Krumschmidt 2021-12-15 19:49:53 +01:00 committed by GitHub
parent bb7de096dc
commit e2a425e4e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dialects/sqlite3/schema/ddl.js
View File

@ -126,7 +126,7 @@ class SQLite3_DDL {
const newTable = compileCreateTable(parsedTable, this.wrap);
return this.alter(newTable, createIndices);
return this.generateAlterCommands(newTable, createIndices);
}
async dropColumn(columns) {

4
lib/dialects/sqlite3/schema/sqlite-tablecompiler.js
View File

@ -61,9 +61,9 @@ class TableCompiler_SQLite3 extends TableCompiler {
this.pushQuery({
sql: `PRAGMA table_info(${this.tableName()})`,
output(pragma) {
statementsProducer(pragma, connection) {
return compiler.client
.ddl(compiler, pragma, this.connection)
.ddl(compiler, pragma, connection)
.alterColumn(columnsInfo);
},
});

6
test/integration2/schema/alter.spec.js
View File

@ -170,7 +170,7 @@ describe('Schema', () => {
);
});
it.skip('generates correct SQL commands when altering columns', async () => {
it('generates correct SQL commands when altering columns', async () => {
const builder = knex.schema.alterTable('alter_table', (table) => {
table.string('column_integer').alter();
});
@ -180,8 +180,8 @@ describe('Schema', () => {
expect(queries.sql).to.deep.equal([
"CREATE TABLE `_knex_temp_alter111` (`column_integer` varchar(255), `column_string` varchar(255), `column_datetime` datetime, `column_defaultTo` integer DEFAULT '0', `column_notNullable` varchar(255) NOT NULL, `column_defaultToAndNotNullable` datetime NOT NULL DEFAULT '0', `column_nullable` boolean NULL)",
'INSERT INTO _knex_temp_alter111 SELECT * FROM alter_table;',
'DROP TABLE "alter_table"',
'ALTER TABLE "_knex_temp_alter111" RENAME TO "alter_table"',
"DROP TABLE 'alter_table'",
"ALTER TABLE '_knex_temp_alter111' RENAME TO 'alter_table'",
]);
});
});