Brian Lauber
31c5b86ec4
Fix: Transaction_OracleDB can use config.connection ( #3731 )
2020-03-15 20:30:40 +01:00
Brian Lauber
37d9c30347
Fix/method binding on knex proxy ( #3717 )
...
* knex methods are proxies for context methods ...
... as opposed to injecting the methods directly onto the knex
function. (Which was then causing `this` to point to the wrong
object when evaluating the context methods)
* Moved CONTEXT_METHODS constant to a higher scope
* mv knex.context -> this.context
* Extracted KNEX_PROPERTY_DEFINITIONS to module scope ...
... which was possible since all of the properties reference
`this` instead of `knex` now
* shallowCloneFunction no longer accesses _context ...
... instead, it uses the normal context property
* transaction method delegates to _transaction ...
... This way, we can be sure that the lower-level details are
consistent across implementations. Individual implementations
just need to handle the quirks around setting up the `config`
and `outerTx`
* CONTEXT_METHODS shared. Fixed override of withUserParams ...
Restructured the code so that CONTEXT_METHODS populates the
KNEX_PROPERTY_DEFINITIONS with the proxy methods.
In doing so, it also exposed the fact that the withUserParams(..)
method was being overridden on the Transactor instead of its
context. So, that bug was fixed as well.
* Added a TODO to remove client.makeKnex(..) in future PR
* Added a warning about QueryBuilder.extend(..) and side-effects
2020-03-11 16:05:03 -04:00
Brian Lauber
0f523db957
Removed .should(..) syntax from test cases ( #3713 )
2020-03-09 10:10:33 -04:00
Brian Lauber
9d07bc97ea
Removed some globals from tests ( #3712 )
...
* `chai` is no longer global
* sinon is no longer globally defined
* expect(..) is no longer defined globally
* Removed obsolete eslint hints about globals
* Removed unused variable ( `expect(..)` )
2020-03-08 19:48:23 -04:00
Brian Lauber
d00bd8d2dd
Fix: Added missing call to _reject in Transactor#transaction ( #3706 )
2020-03-07 01:53:33 +01:00
Brian Lauber
4006bddbcf
Fixed a few unhandled Promise rejections in a test case ( #3705 )
2020-03-06 22:26:34 +01:00
Brian Lauber
1ae9312fa4
Updated .gitignore files to ignore testing artifacts ( #3709 )
2020-03-06 22:24:24 +01:00
Igor Savin
b80966a60e
Cleanup/extract transaction ordering logic (implementation 2.0) ( #3698 )
2020-03-05 21:40:33 +01:00
Brian Lauber
05fedd9e11
Mark missing test cases as "pending" rather than "passed" ( #3695 )
...
* Missing test cases are marked as "pending" rather than "passed"
* Work-around for connection disposal bug in pooling logic...
See this conversation thread for more info: https://github.com/knex/knex/issues/3636#issuecomment-592005391
2020-03-02 01:04:01 +01:00
maximelkin
dc30abf39e
bugfix mysql query errors ignored ( #3690 )
2020-02-29 00:16:07 +01:00
lando-cal
3bea3f66ec
Add OracleDB handling for buffer type in fetchAsString ( #3685 )
...
As released in [2.3.0](https://github.com/oracle/node-oracledb/blob/master/CHANGELOG.md#node-oracledb-v230-7-jun-2018 ) of node-oracledb, this adds handling to fetchAsString for the `BUFFER` type, allowing fetchAsString to interpret `RAW` fields.
2020-02-25 01:27:33 +01:00
maximelkin
8159f04c12
Remove dependency on bluebird methods from tests ( #3682 )
...
* Remove dependency on bluebird methods from tests
* Introduce `"chai-as-promised"` plugin
* Minor enhancements to the testing logic
2020-02-24 19:24:30 -05:00
Jake Coffman
d50d00644c
oracledb: commit was a no-op causing race conditions ( #3668 )
...
The underlying issue was that query *always* committed, even during a transaction. The previous fix was to just disable commitAsync in a transaction but then that also disabled explicit commit calls. Instead, this fix disables query's commits during transactions so that explicit commits still work.
2020-02-16 20:26:13 +01:00
Brian Lauber
2c206a8fec
Fix: Knex CLI calls process.chdir() before opening Knexfile ( #3661 )
2020-02-13 08:58:33 +01:00
maximelkin
88d832cd36
replace Bluebird.timeout ( #3634 )
2020-02-12 21:42:15 +01:00
Brian Lauber
947273e24a
Improve Support for Liftoff's Preloaders ( #3613 )
2020-02-08 17:23:44 +01:00
Igor Savin
c14252d907
Refactor more tests to use cli-testlab ( #3640 )
2020-01-28 02:28:40 +01:00
Mr D
65086025c0
#3751 : Esm interop flag ( #3616 )
2020-01-14 21:01:31 +01:00
yeonhoyoon
4a2fa3b6c9
Print help only when there are no arguments ( #3617 )
2020-01-14 20:58:28 +01:00
Jake Coffman
22558209d4
dispose Oracle connection on connection error ( #3611 )
...
Co-authored-by: abskmj <abskmj@gmail.com>
2020-01-05 18:47:32 +01:00
Igor Savin
80a2516734
Throw better error when trying to modify schema while using unsupported dialect ( #3609 )
2020-01-05 00:04:41 +01:00
Kabir Baidhya
2800e72d2f
Add tests for some of the string utility functions ( #3568 )
2020-01-04 22:59:41 +01:00
Jake Coffman
07997279b7
fix #3605 not releasing connection from pool on disconnect ( #3606 )
2020-01-04 22:56:14 +01:00
Igor Savin
4feefdf3d2
Enforce Unix (lf) line terminators ( #3598 )
2019-12-29 20:28:40 +01:00
Igor Savin
9b37c9480b
Return more information about empty updates ( #3597 )
2019-12-28 22:36:14 +01:00
Ahmed Ashour
a613fe23df
Fix some spelling mistakes ( #3572 )
2019-12-10 22:53:05 +01:00
MaliaGuerrero
03d6f063d5
Initialize data to buffer instead of string for non-strings ( #3545 )
2019-11-21 19:46:45 +01:00
Lorefnon
79ccb7d8bd
Lift up dialect specific methods in the CreateTableBuilder ( #3532 )
2019-11-21 15:22:29 +01:00
Andrei
07276bcbbb
Add connection string qs to connection params ( #3547 )
2019-11-21 15:21:51 +01:00
Alexandre BODIN
0214f11663
Make sqlite3 hasColumn case insensitive ( #3435 )
2019-11-14 19:31:59 +01:00
Lorefnon
f87b28c3e3
Add support for distinct on for postgres ( #3513 )
...
Resolves #3472
2019-11-11 00:51:47 +01:00
Edvard Chen
0560959fa4
feat: wrap subQuery with parenthesis when it appears as table name ( #3496 )
2019-10-28 21:38:01 +01:00
Oran Epelbaum
f4b6848594
Dynamic connection configuration resolution ( #3497 )
2019-10-27 16:14:18 +01:00
Igor Savin
1c65562440
Prepare 0.20.0 release
2019-10-25 20:17:26 +02:00
EthanHur
2d0459111d
orderBy accepts QueryBuilder ( #3491 )
2019-10-24 16:08:12 +02:00
EthanHur
c53227564d
add validation in .offset() ( #2908 )
2019-10-15 13:24:49 +02:00
maximelkin
531714804b
Use util.promisify instead of Bluebird.promisify ( #3470 )
2019-10-15 09:11:59 +02:00
maximelkin
c9e305760d
Fix oracledb driver v4 support ( #3480 )
2019-10-15 08:23:07 +02:00
Lorefnon
b0c0db601a
Fix some issues around seed and migration generation ( #3479 )
2019-10-13 13:19:53 +02:00
Nekrasov Ilya
6b9fb0ec01
disable_migrations_list_validation_feature ( #3448 )
2019-10-12 21:45:39 +02:00
maximelkin
4a71315e9c
remove bluebird.each ( #3471 )
2019-10-12 21:39:34 +02:00
Lorefnon
20bd04b594
Fix bugs in replacement logic used when dropping columns in SQLite. ( #3476 )
2019-10-11 22:38:01 +02:00
maximelkin
f56eaf5cfc
Bluebird remove map mapSeries ( #3474 )
2019-10-11 10:12:56 +02:00
EthanHur
f782348da7
replace Bluebird.map to Promise.all ( #3469 )
2019-10-09 14:39:45 +02:00
Igor Savin
e112a21597
Remove unneeded logging
2019-10-06 23:23:38 +02:00
Taras Ozarko
78a7e9aa4f
fix CLI tests fails caused by PR #3416 ( #3466 )
2019-10-06 23:18:56 +02:00
Igor Savin
988fb24389
Fix MSSQL escaping ( #3382 )
2019-10-06 20:21:32 +02:00
Igor Savin
516b074790
Enable linting in CI ( #3450 )
2019-10-06 20:20:46 +02:00
Roland Németh
c1d20270d6
Fix handling of multiline SQL in SQLite3 schema ( #3411 )
2019-10-06 18:27:52 +02:00
Igor Savin
53d8649ef3
Update test to accommodate for increased precision in PG 12 ( #3465 )
2019-10-06 18:23:00 +02:00
