The underlying issue was that query *always* committed, even during a transaction. The previous fix was to just disable commitAsync in a transaction but then that also disabled explicit commit calls. Instead, this fix disables query's commits during transactions so that explicit commits still work.
* Fixed some of the tests failing with various dialect combinations
* Setup all test databases to run in docker
* Fixed test suite and updated travis to use docker
* Fixed some tests in master and disabled oracle tests while setting everything else to work again
* Changed docker to use latest postgresql alpine image
* Re-enabled all oracledb tests
* Install oracle client libs to oracle server and copy them to travis to make node oracledb package to work
* Disabled random failing oracle tests and added test to show that oracle update in transaction does not seem to work ACID
* Update package.json
* Update package.json
* Fixed linting issues
* Fixed waiting for postgres to use the same DB image that database is using.
* Removed installing oracledb driver in travis if not needed .travis.yml
* Cleaned up package.json more
* Created static name for oracledb container to allow copying files out of it on different docker versions
* Removed webpack from deps
* Fix event listener duplication. Start executing more tests in CI; fix broken test.
* Fix listener
* Fix listener
* Fix Node 6 support
* There doesn't seem to be a clear way to fix listener behaviour in Node 6, so let's just ignore it for the time being, especially considering that we are dropping support for Node 6 in April anyway.
* Update migration guide
* Kill queries after timeout for PostgreSQL
* Fix cancellation connection acquiring and test.
* Fix releasing connection in case query cancellation fails
* Add support for native enums on Postgres (#2632)
Reference https://www.postgresql.org/docs/current/static/sql-createtype.htmlCloses#394
Signed-off-by: Will Soto <will.soto9@gmail.com>
* Removal of 'skim' (#2520)
* Allow overwriting log functions (#2625)
* Example build of custom log functions
* Handle logger object better for transactions
* Adjust test to ignore sqlite warning message
* Fixed onIn with empty values array (#2513)
* Drop support for strong-oracle (#2487)
* Remove babel-plugin-lodash (#2634)
While in theory, this may reduce the bundle size,
in practice it adds a ton of overhead during startup
due to the number of additional requires. Bundle
size also shouldn't matter for server side modules.
* Add json support to the query builder for mysql (#2635)
* Add json support to the query builder for mysql
refs #1036
Based on #1902
* Clarify supported version
* fix wrapIdentifier not being called in postgres alter column (#2612)
* fix wrapIdentifier not being called in postgres alter column
* add test for wrapIdentifier call in postgres alter column
* add comment regarding issue
* add issue & PR #'s in comment
* Remove readable-stream and safe-buffer (#2640)
* Add json support to the query builder for mysql
refs #1036
Based on #1902
* Clarify supported version
* Use native Buffer and Stream implementations
* fixes 2630 (#2642)
* Timeout errors shouldn't silently ignore the passed errors, but rather reject with original error. Fixes#2582 (#2626)
* chore: add Node.js 10 (#2594)
* chore: add Node.js 10
* chore: trigger new build
* chore: update lockfile
* chore: trigger new build
* fix: use npm i instead of npm ci
* Fix mssql driver crashing (#2637)
* Run SQL Server tests locally running SQL server in docker
* WIP mssql test stuff
* Patched MSSQL driver to not crash knex anymore
* Removed semicolon from rollback stmt for oracle (#2564)
* Remove WebSQL dialect (#2647)
* Add json support to the query builder for mysql
refs #1036
Based on #1902
* Clarify supported version
* Use native Buffer and Stream implementations
* Remove WebSQL dialect
* add homepage field to package.json (#2650)
* Make the stream catch errors in the query (#2638)
* Make the stream catch errors in the query
* Fix another case in which stream doesnt emits error
* Linter stuff
* Remove setTimeout in tests
* Make a test not to check the MySQL error code
* Fix stream error catching for MariaDB and PostgreSQL
* Fix stream error catching in Oracle
* Throw the error after emitting it to the stream
* Throw the error without instantiating a new Error
* Various fixes to mssql dialect (#2653)
* Fixed float type of mssql to be float
* Many tests where postgres test was not actually ran at all
* Migrations to be mssql compatible
Mssql driver doesn't handle if multiple queries are sent to same transaction concurrently.
* Prevented mssql failing when invalid schema builder was executed by accident
Instead of trying to generate sql from broken schema calls, just make exception to leak before query compiling is started
* Fixed mssql trx rollback to always throw an error
Also modified some connection test query to be mssql compatible
* Fixed various bugs from MSSQL driver to make tests run
* Fixed mssql unique index to be compatible with other dialect implementations
* Enable running mssql tests on CI
* Test for #2588
* Updated tests to not be dependend on tables left from previous test rans
* Trying to make mssql server work on travis
* Updated changelog and version
* Drop mariadb support (#2681)
* Dropped support for mariasql
* ESLint
* Fixed docs to build again
* Fix knex.initialize() and adds test (#2477)
* Fix knex.initialize() and adds test
* Fix knex.initialize() and adds test
* Added test for reinitializing pool after destroy
* Fixed destroy / reinitialization test
* Fixed the fix
* Implement missing schema support for mssql dialect
* chore: Update dependencies. Remove estraverse (#2691)
* Update dependencies. Remove estraverse
* Fix compatibility with new Sinon
* Increase mssql timeout
* Normalized and validated driverNames of test db clients and fixed oracle test setup (#2692)
* Normalized and validated driverNames of test db clients and fixed oracle test setup
* Fixed failed queries from old query building tests which hadn't been ran in ages
* Allow selecting node version which is used to run oracledb docker tests
* Improved sql tester error messages
* Fixed rest of the oracledb tests
* Removed invalid flag from docker-compose
* Print mssql logs if initialization fails
* Fixed syntax error + final tests
* Added restart of failure for mssql DB initialization to try again if server was not ready
* Printout always mssql logs after container is started
* Fixed wait time printing after trying to connect
* Use npm run oracledb:test for testing oracle in travis
* Add Prettier (#2697)
* Add prettier
* Run files through prettier
* Istanbul -> NYC (#2700)
* istanbul -> nyc
* Update mocha
* Enforce code coverage (#2702)
* Enforce code coverage
* Update coverage numbers with current values
* version assignment on base class, copy on tx client, fix#2705
* Update changelog
* v0.15.1
* Added build step to test script. Fixes#2541 (#2712)
* Revert "Added build step to test script. Fixes#2541 (#2712)" (#2714)
This reverts commit 90ed8db58053b859a6bdc45a17f2f510ce8a3411.
* Allow oracle failures for now
* Fix issue with select(0) (#2711)
* Fix issue with select(0). Fixes#2658
* Refactor migrator (#2695)
* Refactor migrator
* Fix exports
* Fix ESLint
* Fix migrator
* Fix reference to config
* Split some more
* Fix table builder
* Fix argument order
* Merge branch 'master' of https://github.com/tgriesser/knex into feature/2690-support-multiple-migration-dirs
# Conflicts:
# src/migrate/index.js
# test/index.js
# test/unit/migrate/migrator.js
* Fix#2715 (#2721)
* Fix#2715, explicitly set precision in datetime & timestamp
* Allow for precision in knex.fn.now, mysql time
* Add test for datetime with precision
* Bump changelog
* 0.15.2
* Fix issues with warnPromise when migration does not return a promise. Fixes#2725 (#2730)
* Add tests for multiple union arguments with callbacks and builders (#2749)
* Add tests for multiple union arguments
* Add some callback and raw tests to union unit tests
* Compile with before update so that bindings are put in correct order (#2733)
* Fix join using builder withSchema. (#2744)
* Use Datetime2 for MSSQL datetime + timestamp types (#2757)
* Use Datetime2 for MSSQL datetime + timestamp types
Datetime2 is now the recommended column type for new date work: https://docs.microsoft.com/en-us/sql/t-sql/data-types/datetime-transact-sql?view=sql-server-2017
* Add tests for MSSQL datetime2 changes
* General/document breaking change (#2774)
* Add changelog entry for a breaking change
* Improve entry
* Allow timestamp with timezone on mssql databases (#2724)
* Allow timestamp with timezone on mssql databases
* Change timestamp parameter to use object instead of boolean
* Update dependencies (#2772)
* Feature/2690: Multiple migration directories (#2735)
* Implement support for multiple migration directories
* Add tests for new functionality
* Fix tape tests
* Pass migration directory upwards
* Fix multiple directory support
* Fix bugs
* Rollback correctly
* Fix remaining tests
* Address comments
* #2758: Implement fail-fast logic for dialect resolution (#2776)
* Implement fail-fast logic for dialect resolution, clean-up code around.
* Remove method that was deprecated long time ago
* Address additional comments
* Try addressing comments
* Set client explicitly
* Fix compatibility with older Node versions
* Use columnize instead of wrap in using(). (#2713)
* Use columnize instead of wrap in using().
This is an attempt to fix#2136. Also added an integration test, couldn't find any existing.
* Exclude MSSQL from test as it does not support .using
* Change test to not use subquery
* Change test
* Introduced abstraction for getting migrations (#2775)
* Introduced abstraction for getting migrations
This would allow a webpack migration source which is compatible with bundling.
* Fixed migration validation with custom migration source
* Fixed issues after rebasing on muti directory PR
* Renamed parameter and fixed error message
* Addressed some PR comments
* Finished comment
* Moved filename extension filtering into fs-migrator
* Added test showing in memory custom migration source
* Cleaned up how to get config
* Fixed failing test
* Hopefully fix tests
* Fix Node.js 10 support in tests
* Test for correctly releasing cancel query connection
* Pass migration config object as an argument to the migrations themselves, to allow custom parameters to be set for migrations. (#2014)
* Run prettier
* Remove unneeded change
* Remove more unneeded changes
* Fix Node 10 support
* Update documentation based on a new design
* Restore test execution (oops)
* Fix withUserParams method
* Fix knex instance cloning
* Remove unused import
* Fix reference to knex from migrator
* Do not lose user params on transactions
* Remove unneeded require
* Address review comments
* Fix setting event emitter and listeners on Knex copies. Use knex copies to run tests in CI
* Remove knex cloning
* Fix event listener leak
* Use columnize instead of wrap in using().
This is an attempt to fix#2136. Also added an integration test, couldn't find any existing.
* Exclude MSSQL from test as it does not support .using
* Change test to not use subquery
* Change test
* Normalized and validated driverNames of test db clients and fixed oracle test setup
* Fixed failed queries from old query building tests which hadn't been ran in ages
* Allow selecting node version which is used to run oracledb docker tests
* Improved sql tester error messages
* Fixed rest of the oracledb tests
* Removed invalid flag from docker-compose
* Print mssql logs if initialization fails
* Fixed syntax error + final tests
* Added restart of failure for mssql DB initialization to try again if server was not ready
* Printout always mssql logs after container is started
* Fixed wait time printing after trying to connect
* Use npm run oracledb:test for testing oracle in travis
* Fixed float type of mssql to be float
* Many tests where postgres test was not actually ran at all
* Migrations to be mssql compatible
Mssql driver doesn't handle if multiple queries are sent to same transaction concurrently.
* Prevented mssql failing when invalid schema builder was executed by accident
Instead of trying to generate sql from broken schema calls, just make exception to leak before query compiling is started
* Fixed mssql trx rollback to always throw an error
Also modified some connection test query to be mssql compatible
* Fixed various bugs from MSSQL driver to make tests run
* Fixed mssql unique index to be compatible with other dialect implementations
* Enable running mssql tests on CI
* Test for #2588
* Updated tests to not be dependend on tables left from previous test rans
* Trying to make mssql server work on travis
* Make the stream catch errors in the query
* Fix another case in which stream doesnt emits error
* Linter stuff
* Remove setTimeout in tests
* Make a test not to check the MySQL error code
* Fix stream error catching for MariaDB and PostgreSQL
* Fix stream error catching in Oracle
* Throw the error after emitting it to the stream
* Throw the error without instantiating a new Error
* Add a Redshift dialect that inherits from Postgres.
* Turn .index() and .dropIndex() into no-ops with warnings in the Redshift dialect.
* Update the Redshift dialect to be compatible with master.
* Update package.json
* Disable liftoff cli
* Remove the CLI
* Add lib to the repo
* Allow the escaping of named bindings.
* Update dist
* Update the Redshift dialect’s instantiation of the query and column compilers.
* Update the distribution
* Fix a merge conflict
* Take lib back out
* Trying to bring back in line with tgreisser/knex
* Add npm 5 package-lock
* Bring cli.js back in line
* Bring cli.js back in line
* Progress commit on redshift integration tests
* Revert "Progress commit on redshift integration tests"
This reverts commit 207e31635c638853dec54ce0580d34559ba5a54c.
* Progress commit
* Working not null on primary columns in createTable
* Working redshift unit tests
* Working unit and integration tests, still need to fix migration tests
* Brought datatypes more in line with what redshift actually supports
* Added query compiler unit tests
* Add a hacky returning clause for redshift ugh
* Working migration integration tests
* Working insert integration tests
* Allow multiple insert returning values
* Working select integration tests
* Working join integration tests
* Working aggregate integration tests
* All integration suite tests working
* Put docker index for reconnect tests back
* Redshift does not support insert...returning, there does not seem to be a way around that, therefore accept it and test accordingly
* Leave redshift integration tests in place, but do not run them by default
* Fix mysql order by test
* Fix more tests
* Change test db name to knex_test for consistency
* Address PR comments
* Sublime Text gitignore
* Redshift does not support adding more than one column in alter table
* Fix integration tests for redshift
* Linter
* Combine dialect test skip if clause
