From 9191613d2a87b8ced73fe6a13f853de08556a46f Mon Sep 17 00:00:00 2001 From: Qu Date: Wed, 3 Apr 2024 14:41:12 +0800 Subject: [PATCH] fix(knext): bugfix in dag construction (#192) --- python/knext/knext/common/base/chain.py | 1 + python/knext/knext/common/base/component.py | 2 +- python/knext/knext/common/template.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/python/knext/knext/common/base/chain.py b/python/knext/knext/common/base/chain.py index 6d2f0970..b02176d0 100644 --- a/python/knext/knext/common/base/chain.py +++ b/python/knext/knext/common/base/chain.py @@ -81,5 +81,6 @@ class Chain(Runnable, RESTable): for end_node in end_nodes: for start_node in start_nodes: combined_dag.add_edge(end_node, start_node) + dag_list.append(combined_dag) final_dag = nx.compose_all(dag_list) return Chain(dag=final_dag) diff --git a/python/knext/knext/common/base/component.py b/python/knext/knext/common/base/component.py index 4eb3a377..e9a51e28 100644 --- a/python/knext/knext/common/base/component.py +++ b/python/knext/knext/common/base/component.py @@ -105,7 +105,7 @@ class Component(Runnable, RESTable, ABC): if len(end_nodes) > 0 and len(start_nodes) > 0: for end_node in end_nodes: for start_node in start_nodes: - combined_dag.add_edge(end_node, start_node) + dag.add_edge(end_node, start_node) combined_dag = nx.compose(dag, o.dag) dag_list.append(combined_dag) final_dag = nx.compose_all(dag_list) diff --git a/python/knext/knext/common/template.py b/python/knext/knext/common/template.py index ac1d0581..2ae63cda 100644 --- a/python/knext/knext/common/template.py +++ b/python/knext/knext/common/template.py @@ -21,7 +21,7 @@ from stat import S_IWUSR as OWNER_WRITE_PERMISSION def render_template( root: Union[str, os.PathLike], file: Union[str, os.PathLike], **kwargs: Any ) -> None: - env = Environment(loader=FileSystemLoader(root)) + env = Environment(loader=FileSystemLoader(root), autoescape=False) template = env.get_template(str(file)) content = template.render(kwargs)