2021-02-08 16:02:49 -08:00
|
|
|
/**
|
|
|
|
* Copyright 2017 Google Inc. All rights reserved.
|
|
|
|
* Modifications copyright (c) Microsoft Corporation.
|
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
import { execSync } from 'child_process';
|
|
|
|
import * as os from 'os';
|
2021-02-11 06:36:15 -08:00
|
|
|
import path from 'path';
|
2021-02-08 16:02:49 -08:00
|
|
|
import * as util from 'util';
|
|
|
|
import { getUbuntuVersionSync } from './ubuntuVersion';
|
|
|
|
import { assert, getFromENV } from './utils';
|
|
|
|
|
2021-06-08 09:34:17 -07:00
|
|
|
export type BrowserName = 'chromium'|'webkit'|'firefox'|'firefox-beta'|'ffmpeg'|'webkit-technology-preview';
|
|
|
|
export const allBrowserNames: Set<BrowserName> = new Set(['chromium', 'webkit', 'firefox', 'ffmpeg', 'webkit-technology-preview', 'firefox-beta']);
|
2021-02-08 16:02:49 -08:00
|
|
|
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 11:43:29 -07:00
|
|
|
const PACKAGE_PATH = path.join(__dirname, '..', '..');
|
|
|
|
|
2021-02-08 16:02:49 -08:00
|
|
|
type BrowserPlatform = 'win32'|'win64'|'mac10.13'|'mac10.14'|'mac10.15'|'mac11'|'mac11-arm64'|'ubuntu18.04'|'ubuntu20.04';
|
|
|
|
type BrowserDescriptor = {
|
|
|
|
name: BrowserName,
|
|
|
|
revision: string,
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 11:43:29 -07:00
|
|
|
installByDefault: boolean,
|
2021-03-17 09:34:09 -07:00
|
|
|
browserDirectory: string,
|
2021-02-08 16:02:49 -08:00
|
|
|
};
|
|
|
|
|
|
|
|
const EXECUTABLE_PATHS = {
|
2021-03-31 13:32:10 -05:00
|
|
|
'chromium': {
|
2021-02-08 16:02:49 -08:00
|
|
|
'ubuntu18.04': ['chrome-linux', 'chrome'],
|
|
|
|
'ubuntu20.04': ['chrome-linux', 'chrome'],
|
|
|
|
'mac10.13': ['chrome-mac', 'Chromium.app', 'Contents', 'MacOS', 'Chromium'],
|
|
|
|
'mac10.14': ['chrome-mac', 'Chromium.app', 'Contents', 'MacOS', 'Chromium'],
|
|
|
|
'mac10.15': ['chrome-mac', 'Chromium.app', 'Contents', 'MacOS', 'Chromium'],
|
|
|
|
'mac11': ['chrome-mac', 'Chromium.app', 'Contents', 'MacOS', 'Chromium'],
|
|
|
|
'mac11-arm64': ['chrome-mac', 'Chromium.app', 'Contents', 'MacOS', 'Chromium'],
|
|
|
|
'win32': ['chrome-win', 'chrome.exe'],
|
|
|
|
'win64': ['chrome-win', 'chrome.exe'],
|
|
|
|
},
|
2021-03-31 13:32:10 -05:00
|
|
|
'firefox': {
|
2021-02-08 16:02:49 -08:00
|
|
|
'ubuntu18.04': ['firefox', 'firefox'],
|
|
|
|
'ubuntu20.04': ['firefox', 'firefox'],
|
|
|
|
'mac10.13': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'mac10.14': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'mac10.15': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'mac11': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'mac11-arm64': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'win32': ['firefox', 'firefox.exe'],
|
|
|
|
'win64': ['firefox', 'firefox.exe'],
|
|
|
|
},
|
2021-06-08 09:34:17 -07:00
|
|
|
'firefox-beta': {
|
2021-04-19 23:26:33 -05:00
|
|
|
'ubuntu18.04': ['firefox', 'firefox'],
|
|
|
|
'ubuntu20.04': ['firefox', 'firefox'],
|
|
|
|
'mac10.13': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'mac10.14': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'mac10.15': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'mac11': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'mac11-arm64': ['firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox'],
|
|
|
|
'win32': ['firefox', 'firefox.exe'],
|
|
|
|
'win64': ['firefox', 'firefox.exe'],
|
|
|
|
},
|
2021-03-31 13:32:10 -05:00
|
|
|
'webkit': {
|
2021-02-08 16:02:49 -08:00
|
|
|
'ubuntu18.04': ['pw_run.sh'],
|
|
|
|
'ubuntu20.04': ['pw_run.sh'],
|
|
|
|
'mac10.13': undefined,
|
|
|
|
'mac10.14': ['pw_run.sh'],
|
|
|
|
'mac10.15': ['pw_run.sh'],
|
|
|
|
'mac11': ['pw_run.sh'],
|
|
|
|
'mac11-arm64': ['pw_run.sh'],
|
|
|
|
'win32': ['Playwright.exe'],
|
|
|
|
'win64': ['Playwright.exe'],
|
|
|
|
},
|
2021-03-31 13:32:10 -05:00
|
|
|
'webkit-technology-preview': {
|
|
|
|
'ubuntu18.04': ['pw_run.sh'],
|
|
|
|
'ubuntu20.04': ['pw_run.sh'],
|
|
|
|
'mac10.13': undefined,
|
|
|
|
'mac10.14': ['pw_run.sh'],
|
|
|
|
'mac10.15': ['pw_run.sh'],
|
|
|
|
'mac11': ['pw_run.sh'],
|
|
|
|
'mac11-arm64': ['pw_run.sh'],
|
|
|
|
'win32': ['Playwright.exe'],
|
|
|
|
'win64': ['Playwright.exe'],
|
|
|
|
},
|
|
|
|
'ffmpeg': {
|
2021-02-08 16:02:49 -08:00
|
|
|
'ubuntu18.04': ['ffmpeg-linux'],
|
|
|
|
'ubuntu20.04': ['ffmpeg-linux'],
|
|
|
|
'mac10.13': ['ffmpeg-mac'],
|
|
|
|
'mac10.14': ['ffmpeg-mac'],
|
|
|
|
'mac10.15': ['ffmpeg-mac'],
|
|
|
|
'mac11': ['ffmpeg-mac'],
|
|
|
|
'mac11-arm64': ['ffmpeg-mac'],
|
|
|
|
'win32': ['ffmpeg-win32.exe'],
|
|
|
|
'win64': ['ffmpeg-win64.exe'],
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
|
|
|
const DOWNLOAD_URLS = {
|
2021-03-31 13:32:10 -05:00
|
|
|
'chromium': {
|
2021-02-08 16:02:49 -08:00
|
|
|
'ubuntu18.04': '%s/builds/chromium/%s/chromium-linux.zip',
|
|
|
|
'ubuntu20.04': '%s/builds/chromium/%s/chromium-linux.zip',
|
|
|
|
'mac10.13': '%s/builds/chromium/%s/chromium-mac.zip',
|
|
|
|
'mac10.14': '%s/builds/chromium/%s/chromium-mac.zip',
|
|
|
|
'mac10.15': '%s/builds/chromium/%s/chromium-mac.zip',
|
|
|
|
'mac11': '%s/builds/chromium/%s/chromium-mac.zip',
|
|
|
|
'mac11-arm64': '%s/builds/chromium/%s/chromium-mac-arm64.zip',
|
|
|
|
'win32': '%s/builds/chromium/%s/chromium-win32.zip',
|
|
|
|
'win64': '%s/builds/chromium/%s/chromium-win64.zip',
|
|
|
|
},
|
2021-03-31 13:32:10 -05:00
|
|
|
'firefox': {
|
2021-02-08 16:02:49 -08:00
|
|
|
'ubuntu18.04': '%s/builds/firefox/%s/firefox-ubuntu-18.04.zip',
|
2021-04-03 00:08:04 -05:00
|
|
|
'ubuntu20.04': '%s/builds/firefox/%s/firefox-ubuntu-20.04.zip',
|
2021-02-08 16:02:49 -08:00
|
|
|
'mac10.13': '%s/builds/firefox/%s/firefox-mac-10.14.zip',
|
|
|
|
'mac10.14': '%s/builds/firefox/%s/firefox-mac-10.14.zip',
|
|
|
|
'mac10.15': '%s/builds/firefox/%s/firefox-mac-10.14.zip',
|
|
|
|
'mac11': '%s/builds/firefox/%s/firefox-mac-10.14.zip',
|
|
|
|
'mac11-arm64': '%s/builds/firefox/%s/firefox-mac-11.0-arm64.zip',
|
|
|
|
'win32': '%s/builds/firefox/%s/firefox-win32.zip',
|
|
|
|
'win64': '%s/builds/firefox/%s/firefox-win64.zip',
|
|
|
|
},
|
2021-06-08 09:34:17 -07:00
|
|
|
'firefox-beta': {
|
|
|
|
'ubuntu18.04': '%s/builds/firefox-beta/%s/firefox-beta-ubuntu-18.04.zip',
|
|
|
|
'ubuntu20.04': '%s/builds/firefox-beta/%s/firefox-beta-ubuntu-20.04.zip',
|
|
|
|
'mac10.13': '%s/builds/firefox-beta/%s/firefox-beta-mac-10.14.zip',
|
|
|
|
'mac10.14': '%s/builds/firefox-beta/%s/firefox-beta-mac-10.14.zip',
|
|
|
|
'mac10.15': '%s/builds/firefox-beta/%s/firefox-beta-mac-10.14.zip',
|
|
|
|
'mac11': '%s/builds/firefox-beta/%s/firefox-beta-mac-10.14.zip',
|
|
|
|
'mac11-arm64': '%s/builds/firefox-beta/%s/firefox-beta-mac-11.0-arm64.zip',
|
|
|
|
'win32': '%s/builds/firefox-beta/%s/firefox-beta-win32.zip',
|
|
|
|
'win64': '%s/builds/firefox-beta/%s/firefox-beta-win64.zip',
|
2021-04-19 23:26:33 -05:00
|
|
|
},
|
2021-03-31 13:32:10 -05:00
|
|
|
'webkit': {
|
2021-02-08 16:02:49 -08:00
|
|
|
'ubuntu18.04': '%s/builds/webkit/%s/webkit-ubuntu-18.04.zip',
|
|
|
|
'ubuntu20.04': '%s/builds/webkit/%s/webkit-ubuntu-20.04.zip',
|
|
|
|
'mac10.13': undefined,
|
2021-03-17 09:34:09 -07:00
|
|
|
'mac10.14': '%s/builds/deprecated-webkit-mac-10.14/%s/deprecated-webkit-mac-10.14.zip',
|
2021-02-08 16:02:49 -08:00
|
|
|
'mac10.15': '%s/builds/webkit/%s/webkit-mac-10.15.zip',
|
|
|
|
'mac11': '%s/builds/webkit/%s/webkit-mac-10.15.zip',
|
|
|
|
'mac11-arm64': '%s/builds/webkit/%s/webkit-mac-11.0-arm64.zip',
|
|
|
|
'win32': '%s/builds/webkit/%s/webkit-win64.zip',
|
|
|
|
'win64': '%s/builds/webkit/%s/webkit-win64.zip',
|
|
|
|
},
|
2021-03-31 13:32:10 -05:00
|
|
|
'webkit-technology-preview': {
|
|
|
|
'ubuntu18.04': '%s/builds/webkit/%s/webkit-ubuntu-18.04.zip',
|
|
|
|
'ubuntu20.04': '%s/builds/webkit/%s/webkit-ubuntu-20.04.zip',
|
|
|
|
'mac10.13': undefined,
|
|
|
|
'mac10.14': undefined,
|
|
|
|
'mac10.15': '%s/builds/webkit/%s/webkit-mac-10.15.zip',
|
|
|
|
'mac11': '%s/builds/webkit/%s/webkit-mac-10.15.zip',
|
|
|
|
'mac11-arm64': '%s/builds/webkit/%s/webkit-mac-11.0-arm64.zip',
|
|
|
|
'win32': '%s/builds/webkit/%s/webkit-win64.zip',
|
|
|
|
'win64': '%s/builds/webkit/%s/webkit-win64.zip',
|
|
|
|
},
|
|
|
|
'ffmpeg': {
|
2021-02-08 16:02:49 -08:00
|
|
|
'ubuntu18.04': '%s/builds/ffmpeg/%s/ffmpeg-linux.zip',
|
|
|
|
'ubuntu20.04': '%s/builds/ffmpeg/%s/ffmpeg-linux.zip',
|
|
|
|
'mac10.13': '%s/builds/ffmpeg/%s/ffmpeg-mac.zip',
|
|
|
|
'mac10.14': '%s/builds/ffmpeg/%s/ffmpeg-mac.zip',
|
|
|
|
'mac10.15': '%s/builds/ffmpeg/%s/ffmpeg-mac.zip',
|
|
|
|
'mac11': '%s/builds/ffmpeg/%s/ffmpeg-mac.zip',
|
|
|
|
'mac11-arm64': '%s/builds/ffmpeg/%s/ffmpeg-mac.zip',
|
|
|
|
'win32': '%s/builds/ffmpeg/%s/ffmpeg-win32.zip',
|
|
|
|
'win64': '%s/builds/ffmpeg/%s/ffmpeg-win64.zip',
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
|
|
|
export const hostPlatform = ((): BrowserPlatform => {
|
|
|
|
const platform = os.platform();
|
|
|
|
if (platform === 'darwin') {
|
|
|
|
const [major, minor] = execSync('sw_vers -productVersion', {
|
|
|
|
stdio: ['ignore', 'pipe', 'ignore']
|
|
|
|
}).toString('utf8').trim().split('.').map(x => parseInt(x, 10));
|
|
|
|
let arm64 = false;
|
|
|
|
// BigSur is the first version that might run on Apple Silicon.
|
|
|
|
if (major >= 11) {
|
2021-02-16 10:23:38 -08:00
|
|
|
arm64 = execSync('/usr/sbin/sysctl -in hw.optional.arm64', {
|
2021-02-08 16:02:49 -08:00
|
|
|
stdio: ['ignore', 'pipe', 'ignore']
|
|
|
|
}).toString().trim() === '1';
|
|
|
|
}
|
|
|
|
// We do not want to differentiate between minor big sur releases
|
|
|
|
// since they don't change core APIs so far.
|
|
|
|
const macVersion = major === 10 ? `${major}.${minor}` : `${major}`;
|
|
|
|
const archSuffix = arm64 ? '-arm64' : '';
|
|
|
|
return `mac${macVersion}${archSuffix}` as BrowserPlatform;
|
|
|
|
}
|
|
|
|
if (platform === 'linux') {
|
|
|
|
const ubuntuVersion = getUbuntuVersionSync();
|
|
|
|
if (parseInt(ubuntuVersion, 10) <= 19)
|
|
|
|
return 'ubuntu18.04';
|
|
|
|
return 'ubuntu20.04';
|
|
|
|
}
|
|
|
|
if (platform === 'win32')
|
|
|
|
return os.arch() === 'x64' ? 'win64' : 'win32';
|
|
|
|
return platform as BrowserPlatform;
|
|
|
|
})();
|
|
|
|
|
|
|
|
export const registryDirectory = (() => {
|
2021-02-12 11:12:06 -08:00
|
|
|
let result: string;
|
|
|
|
|
2021-02-08 16:02:49 -08:00
|
|
|
const envDefined = getFromENV('PLAYWRIGHT_BROWSERS_PATH');
|
2021-02-12 11:12:06 -08:00
|
|
|
if (envDefined === '0') {
|
|
|
|
result = path.join(__dirname, '..', '..', '.local-browsers');
|
|
|
|
} else if (envDefined) {
|
|
|
|
result = envDefined;
|
|
|
|
} else {
|
|
|
|
let cacheDirectory: string;
|
|
|
|
if (process.platform === 'linux')
|
|
|
|
cacheDirectory = process.env.XDG_CACHE_HOME || path.join(os.homedir(), '.cache');
|
|
|
|
else if (process.platform === 'darwin')
|
|
|
|
cacheDirectory = path.join(os.homedir(), 'Library', 'Caches');
|
|
|
|
else if (process.platform === 'win32')
|
|
|
|
cacheDirectory = process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local');
|
|
|
|
else
|
|
|
|
throw new Error('Unsupported platform: ' + process.platform);
|
|
|
|
result = path.join(cacheDirectory, 'ms-playwright');
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!path.isAbsolute(result)) {
|
|
|
|
// It is important to resolve to the absolute path:
|
|
|
|
// - for unzipping to work correctly;
|
|
|
|
// - so that registry directory matches between installation and execution.
|
|
|
|
// INIT_CWD points to the root of `npm/yarn install` and is probably what
|
|
|
|
// the user meant when typing the relative path.
|
|
|
|
result = path.resolve(getFromENV('INIT_CWD') || process.cwd(), result);
|
|
|
|
}
|
|
|
|
return result;
|
2021-02-08 16:02:49 -08:00
|
|
|
})();
|
|
|
|
|
|
|
|
export function isBrowserDirectory(browserDirectory: string): boolean {
|
|
|
|
const baseName = path.basename(browserDirectory);
|
|
|
|
for (const browserName of allBrowserNames) {
|
|
|
|
if (baseName.startsWith(browserName + '-'))
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 11:43:29 -07:00
|
|
|
let currentPackageRegistry: Registry | undefined = undefined;
|
|
|
|
|
2021-02-08 16:02:49 -08:00
|
|
|
export class Registry {
|
|
|
|
private _descriptors: BrowserDescriptor[];
|
|
|
|
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 11:43:29 -07:00
|
|
|
static currentPackageRegistry() {
|
|
|
|
if (!currentPackageRegistry)
|
|
|
|
currentPackageRegistry = new Registry(PACKAGE_PATH);
|
|
|
|
return currentPackageRegistry;
|
|
|
|
}
|
|
|
|
|
2021-02-08 16:02:49 -08:00
|
|
|
constructor(packagePath: string) {
|
2021-04-19 22:06:04 +02:00
|
|
|
// require() needs to be used there otherwise it breaks on Vercel serverless
|
|
|
|
// functions. See https://github.com/microsoft/playwright/pull/6186
|
|
|
|
const browsersJSON = require(path.join(packagePath, 'browsers.json'));
|
2021-03-17 09:34:09 -07:00
|
|
|
this._descriptors = browsersJSON['browsers'].map((obj: any) => {
|
|
|
|
const name = obj.name;
|
|
|
|
const revisionOverride = (obj.revisionOverrides || {})[hostPlatform];
|
|
|
|
const revision = revisionOverride || obj.revision;
|
2021-03-31 13:32:10 -05:00
|
|
|
const browserDirectoryPrefix = revisionOverride ? `${name}_${hostPlatform}_special` : `${name}`;
|
2021-03-17 09:34:09 -07:00
|
|
|
return {
|
|
|
|
name,
|
|
|
|
revision,
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 11:43:29 -07:00
|
|
|
installByDefault: !!obj.installByDefault,
|
2021-03-31 13:32:10 -05:00
|
|
|
// Method `isBrowserDirectory` determines directory to be browser iff
|
|
|
|
// it starts with some browser name followed by '-'. Some browser names
|
|
|
|
// are prefixes of others, e.g. 'webkit' is a prefix of `webkit-technology-preview`.
|
|
|
|
// To avoid older registries erroneously removing 'webkit-technology-preview', we have to
|
|
|
|
// ensure that browser folders to never include dashes inside.
|
|
|
|
browserDirectory: browserDirectoryPrefix.replace(/-/g, '_') + '-' + revision,
|
2021-03-17 09:34:09 -07:00
|
|
|
};
|
|
|
|
});
|
2021-02-08 16:02:49 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
browserDirectory(browserName: BrowserName): string {
|
|
|
|
const browser = this._descriptors.find(browser => browser.name === browserName);
|
|
|
|
assert(browser, `ERROR: Playwright does not support ${browserName}`);
|
2021-03-17 09:34:09 -07:00
|
|
|
return path.join(registryDirectory, browser.browserDirectory);
|
2021-02-08 16:02:49 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
revision(browserName: BrowserName): number {
|
|
|
|
const browser = this._descriptors.find(browser => browser.name === browserName);
|
|
|
|
assert(browser, `ERROR: Playwright does not support ${browserName}`);
|
|
|
|
return parseInt(browser.revision, 10);
|
|
|
|
}
|
|
|
|
|
|
|
|
linuxLddDirectories(browserName: BrowserName): string[] {
|
|
|
|
const browserDirectory = this.browserDirectory(browserName);
|
2021-04-20 18:54:53 +02:00
|
|
|
switch (browserName) {
|
|
|
|
case 'chromium':
|
|
|
|
return [path.join(browserDirectory, 'chrome-linux')];
|
|
|
|
case 'webkit':
|
|
|
|
case 'webkit-technology-preview':
|
|
|
|
return [
|
|
|
|
path.join(browserDirectory, 'minibrowser-gtk'),
|
|
|
|
path.join(browserDirectory, 'minibrowser-gtk', 'bin'),
|
|
|
|
path.join(browserDirectory, 'minibrowser-gtk', 'lib'),
|
|
|
|
path.join(browserDirectory, 'minibrowser-wpe'),
|
|
|
|
path.join(browserDirectory, 'minibrowser-wpe', 'bin'),
|
|
|
|
path.join(browserDirectory, 'minibrowser-wpe', 'lib'),
|
|
|
|
];
|
|
|
|
case 'firefox':
|
2021-06-08 09:34:17 -07:00
|
|
|
case 'firefox-beta':
|
2021-04-20 18:54:53 +02:00
|
|
|
return [path.join(browserDirectory, 'firefox')];
|
|
|
|
default:
|
|
|
|
return [];
|
2021-02-08 16:02:49 -08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
windowsExeAndDllDirectories(browserName: BrowserName): string[] {
|
|
|
|
const browserDirectory = this.browserDirectory(browserName);
|
|
|
|
if (browserName === 'chromium')
|
|
|
|
return [path.join(browserDirectory, 'chrome-win')];
|
|
|
|
if (browserName === 'firefox')
|
|
|
|
return [path.join(browserDirectory, 'firefox')];
|
|
|
|
if (browserName === 'webkit')
|
|
|
|
return [browserDirectory];
|
|
|
|
return [];
|
|
|
|
}
|
|
|
|
|
|
|
|
executablePath(browserName: BrowserName): string | undefined {
|
|
|
|
const browserDirectory = this.browserDirectory(browserName);
|
|
|
|
const tokens = EXECUTABLE_PATHS[browserName][hostPlatform];
|
|
|
|
return tokens ? path.join(browserDirectory, ...tokens) : undefined;
|
|
|
|
}
|
|
|
|
|
|
|
|
downloadURL(browserName: BrowserName): string {
|
|
|
|
const browser = this._descriptors.find(browser => browser.name === browserName);
|
|
|
|
assert(browser, `ERROR: Playwright does not support ${browserName}`);
|
|
|
|
const envDownloadHost: { [key: string]: string } = {
|
2021-03-31 13:32:10 -05:00
|
|
|
'chromium': 'PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST',
|
|
|
|
'firefox': 'PLAYWRIGHT_FIREFOX_DOWNLOAD_HOST',
|
2021-06-08 09:34:17 -07:00
|
|
|
'firefox-beta': 'PLAYWRIGHT_FIREFOX_DOWNLOAD_HOST',
|
2021-03-31 13:32:10 -05:00
|
|
|
'webkit': 'PLAYWRIGHT_WEBKIT_DOWNLOAD_HOST',
|
|
|
|
'webkit-technology-preview': 'PLAYWRIGHT_WEBKIT_DOWNLOAD_HOST',
|
|
|
|
'ffmpeg': 'PLAYWRIGHT_FFMPEG_DOWNLOAD_HOST',
|
2021-02-08 16:02:49 -08:00
|
|
|
};
|
|
|
|
const downloadHost = getFromENV(envDownloadHost[browserName]) ||
|
|
|
|
getFromENV('PLAYWRIGHT_DOWNLOAD_HOST') ||
|
|
|
|
'https://playwright.azureedge.net';
|
|
|
|
const urlTemplate = DOWNLOAD_URLS[browserName][hostPlatform];
|
|
|
|
assert(urlTemplate, `ERROR: Playwright does not support ${browserName} on ${hostPlatform}`);
|
|
|
|
return util.format(urlTemplate, downloadHost, browser.revision);
|
|
|
|
}
|
|
|
|
|
2021-04-20 18:54:53 +02:00
|
|
|
isSupportedBrowser(browserName: string): boolean {
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 11:43:29 -07:00
|
|
|
// We retain browsers if they are found in the descriptor.
|
|
|
|
// Note, however, that there are older versions out in the wild that rely on
|
|
|
|
// the "download" field in the browser descriptor and use its value
|
|
|
|
// to retain and download browsers.
|
|
|
|
// As of v1.10, we decided to abandon "download" field.
|
2021-04-20 18:54:53 +02:00
|
|
|
return this._descriptors.some(browser => browser.name === browserName);
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 11:43:29 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
installByDefault(): BrowserName[] {
|
|
|
|
return this._descriptors.filter(browser => browser.installByDefault).map(browser => browser.name);
|
2021-02-08 16:02:49 -08:00
|
|
|
}
|
|
|
|
}
|