yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: make evaluate work with overridden Window/Document/Node (#17288)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/17287
This commit is contained in:
Max Schmitt 2022-09-13 18:21:07 +02:00 committed by GitHub
parent 31743a12c1
commit 00a3b1b0a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/playwright-core/src/server/isomorphic/utilityScriptSerializers.ts
View File

@ -107,11 +107,11 @@ export function source() {
function serialize(value: any, handleSerializer: (value: any) => HandleOrValue, visitorInfo: VisitorInfo): SerializedValue { function serialize(value: any, handleSerializer: (value: any) => HandleOrValue, visitorInfo: VisitorInfo): SerializedValue {
if (value && typeof value === 'object') { if (value && typeof value === 'object') {
if (globalThis.Window && value instanceof globalThis.Window) if (typeof globalThis.Window === 'function' && value instanceof globalThis.Window)
return 'ref: <Window>'; return 'ref: <Window>';
if (globalThis.Document && value instanceof globalThis.Document) if (typeof globalThis.Document === 'function' && value instanceof globalThis.Document)
return 'ref: <Document>'; return 'ref: <Document>';
if (globalThis.Node && value instanceof globalThis.Node) if (typeof globalThis.Node === 'function' && value instanceof globalThis.Node)
return 'ref: <Node>'; return 'ref: <Node>';
} }
return innerSerialize(value, handleSerializer, visitorInfo); return innerSerialize(value, handleSerializer, visitorInfo);

22
tests/page/page-evaluate.spec.ts
View File

@ -680,3 +680,25 @@ it('should work with overridden Object.defineProperty', async ({ page, server })
await page.goto(server.PREFIX + '/test'); await page.goto(server.PREFIX + '/test');
expect(await page.evaluate('1+2')).toBe(3); expect(await page.evaluate('1+2')).toBe(3);
}); });
it('should work with overridden globalThis.Window/Document/Node', async ({ page, server }) => {
const testCases = [
// @ts-ignore
() => globalThis.Window = {},
// @ts-ignore
() => globalThis.Document = {},
// @ts-ignore
() => globalThis.Node = {},
() => globalThis.Window = null,
() => globalThis.Document = null,
() => globalThis.Node = null,
];
for (const testCase of testCases) {
await it.step(testCase.toString(), async () => {
await page.goto(server.EMPTY_PAGE);
await page.evaluate(testCase);
expect(await page.evaluate('1+2')).toBe(3);
expect(await page.evaluate(() => ['foo'])).toEqual(['foo']);
});
}
});