yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: mark driver mode as remote (#15402)

Browse Source 
Otherwise we are passing buffers as objects, not as base64.
This commit is contained in:
Dmitry Gozman 2022-07-06 09:20:07 -07:00 committed by GitHub
parent 21dcc5139d
commit 0142bdce76
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/playwright-core/src/outofprocess.ts
View File

@ -48,6 +48,7 @@ class PlaywrightClient {
this._driverProcess.on('exit', this._onExit.bind(this)); this._driverProcess.on('exit', this._onExit.bind(this));
const connection = new Connection(); const connection = new Connection();
connection.markAsRemote();
this._transport = new IpcTransport(this._driverProcess); this._transport = new IpcTransport(this._driverProcess);
connection.onmessage = message => this._transport.send(JSON.stringify(message)); connection.onmessage = message => this._transport.send(JSON.stringify(message));
this._transport.onmessage = message => connection.dispatch(JSON.parse(message)); this._transport.onmessage = message => connection.dispatch(JSON.parse(message));

2
tests/library/defaultbrowsercontext-1.spec.ts
View File

@ -172,7 +172,7 @@ it('should support offline option', async ({ server, launchPersistent }) => {
}); });
it('should support acceptDownloads option', async ({ server, launchPersistent, mode }) => { it('should support acceptDownloads option', async ({ server, launchPersistent, mode }) => {
it.skip(mode === 'service', 'download.path() is not avaialble in remote mode'); it.skip(mode !== 'default', 'download.path() is not avaialble in remote mode');
const { page } = await launchPersistent(); const { page } = await launchPersistent();
server.setRoute('/download', (req, res) => { server.setRoute('/download', (req, res) => {

4
tests/library/download.spec.ts
View File

@ -21,7 +21,7 @@ import crypto from 'crypto';
import type { Download } from 'playwright-core'; import type { Download } from 'playwright-core';
it.describe('download event', () => { it.describe('download event', () => {
it.skip(({ mode }) => mode === 'service', 'download.path() is not available in remote mode'); it.skip(({ mode }) => mode !== 'default', 'download.path() is not available in remote mode');
it.beforeEach(async ({ server }) => { it.beforeEach(async ({ server }) => {
server.setRoute('/download', (req, res) => { server.setRoute('/download', (req, res) => {
@ -651,7 +651,7 @@ it('should save to user-specified path', async ({ browser, server, mode }, testI
page.waitForEvent('download'), page.waitForEvent('download'),
page.click('a') page.click('a')
]); ]);
if (mode === 'service') { if (mode !== 'default') {
const error = await download.path().catch(e => e); const error = await download.path().catch(e => e);
expect(error.message).toContain('Path is not available when connecting remotely. Use saveAs() to save a local copy.'); expect(error.message).toContain('Path is not available when connecting remotely. Use saveAs() to save a local copy.');
} }

2
tests/library/downloads-path.spec.ts
View File

@ -19,7 +19,7 @@ import fs from 'fs';
import path from 'path'; import path from 'path';
it.describe('downloads path', () => { it.describe('downloads path', () => {
it.skip(({ mode }) => mode === 'service', 'download.path() is not available in remote mode'); it.skip(({ mode }) => mode !== 'default', 'download.path() is not available in remote mode');
it.beforeEach(async ({ server }) => { it.beforeEach(async ({ server }) => {
server.setRoute('/download', (req, res) => { server.setRoute('/download', (req, res) => {

2
tests/library/video.spec.ts
View File

@ -154,7 +154,7 @@ function expectRedFrames(videoFile: string, size: { width: number, height: numbe
it.describe('screencast', () => { it.describe('screencast', () => {
it.slow(); it.slow();
it.skip(({ mode }) => mode === 'service', 'video.path() is not avaialble in remote mode'); it.skip(({ mode }) => mode !== 'default', 'video.path() is not avaialble in remote mode');
it('videoSize should require videosPath', async ({ browser }) => { it('videoSize should require videosPath', async ({ browser }) => {
const error = await browser.newContext({ videoSize: { width: 100, height: 100 } }).catch(e => e); const error = await browser.newContext({ videoSize: { width: 100, height: 100 } }).catch(e => e);