From 036f9e50fab11a996411ee2d6abbc30d4b4e05b9 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Thu, 16 Apr 2020 12:36:00 -0700 Subject: [PATCH] fix(webkit): allow fufilling requests to redirects (#1830) --- src/webkit/wkInterceptableRequest.ts | 2 +- test/interception.spec.js | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/webkit/wkInterceptableRequest.ts b/src/webkit/wkInterceptableRequest.ts index 202b5d8e45..edd9ec7730 100644 --- a/src/webkit/wkInterceptableRequest.ts +++ b/src/webkit/wkInterceptableRequest.ts @@ -69,7 +69,7 @@ export class WKInterceptableRequest implements network.RouteDelegate { await this._interceptedPromise; const base64Encoded = !!response.body && !helper.isString(response.body); - const responseBody = response.body ? (base64Encoded ? response.body.toString('base64') : response.body as string) : undefined; + const responseBody = response.body ? (base64Encoded ? response.body.toString('base64') : response.body as string) : ''; const responseHeaders: { [s: string]: string; } = {}; if (response.headers) { diff --git a/test/interception.spec.js b/test/interception.spec.js index a7f930a2a1..d44bd3a71f 100644 --- a/test/interception.spec.js +++ b/test/interception.spec.js @@ -368,8 +368,7 @@ describe('Page.route', function() { expect(response.ok()).toBe(true); expect(intercepted).toBe(true); }); - // WebKit crashes. Firefox succeeds, but then fails to close. - it.fail(FFOX || WEBKIT)('should create a redirect', async({page, server}) => { + it('should create a redirect', async({page, server}) => { await page.goto(server.PREFIX + '/empty.html'); await page.route('**/*', async(route, request) => { if (request.url() !== server.PREFIX + '/redirect_this')