yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fix recorder downloads test (#5454)

Browse Source
This commit is contained in:
Pavel Feldman 2021-02-12 20:26:22 -08:00 committed by GitHub
parent 3c877374c7
commit 0782b25272
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/server/supplements/recorder/codeGenerator.ts
View File

@ -135,6 +135,11 @@ export class CodeGenerator {
return; return;
} }
if (this._lastAction && !this._lastAction.committed) { if (this._lastAction && !this._lastAction.committed) {
const signals = this._lastAction.action.signals;
if (signal.name === 'navigation' && signals.length && signals[signals.length - 1].name === 'download')
return;
if (signal.name === 'download' && signals.length && signals[signals.length - 1].name === 'navigation')
signals.length = signals.length - 1;
this._lastAction.action.signals.push(signal); this._lastAction.action.signals.push(signal);
this._printAction(this._lastAction, true); this._printAction(this._lastAction, true);
return; return;

4
test/cli/cli-codegen-2.spec.ts
View File

@ -110,9 +110,7 @@ describe('cli codegen', (suite, { mode, browserName, headful }) => {
await page.setInputFiles('input[type="file"]', []);`); await page.setInputFiles('input[type="file"]', []);`);
}); });
it('should download files', (test, {browserName, headful}) => { it('should download files', async ({ page, recorder, httpServer }) => {
test.fixme(browserName === 'webkit' || browserName === 'firefox', 'Generated page.waitForNavigation next to page.waitForEvent(download)');
}, async ({ page, recorder, httpServer }) => {
httpServer.setHandler((req: http.IncomingMessage, res: http.ServerResponse) => { httpServer.setHandler((req: http.IncomingMessage, res: http.ServerResponse) => {
const pathName = url.parse(req.url!).path; const pathName = url.parse(req.url!).path;
if (pathName === '/download') { if (pathName === '/download') {