yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(chromium): disable lazy loading iframes (#3535)

Browse Source 
These do not play nicely with our "page is loaded when all frames
are loaded" logic.
This commit is contained in:
Dmitry Gozman 2020-08-19 15:58:13 -07:00 committed by GitHub
parent f13cebc66d
commit 0a22e2758a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/server/chromium.ts
View File

@ -162,7 +162,7 @@ const DEFAULT_ARGS = [
'--disable-dev-shm-usage',
'--disable-extensions',
// BlinkGenPropertyTrees disabled due to crbug.com/937609
'--disable-features=TranslateUI,BlinkGenPropertyTrees,ImprovedCookieControls,SameSiteByDefaultCookies',
'--disable-features=TranslateUI,BlinkGenPropertyTrees,ImprovedCookieControls,SameSiteByDefaultCookies,LazyFrameLoading',
'--disable-hang-monitor',
'--disable-ipc-flooding-protection',
'--disable-popup-blocking',

6
test/assets/frames/lazy-frame.html Normal file
View File

@ -0,0 +1,6 @@
<div style="height: 1000px; width: 1000px; background: red">One</div>
<div style="height: 1000px; width: 1000px; background: blue">Two</div>
<div style="height: 1000px; width: 1000px; background: red">Three</div>
<div style="height: 1000px; width: 1000px; background: blue">Four</div>
<div style="height: 1000px; width: 1000px; background: red">Five</div>
<iframe loading="lazy" src='./frame.html'></iframe>

5
test/page-goto.spec.ts
View File

@ -491,3 +491,8 @@ it.skip(true)('extraHttpHeaders should be pushed to provisional page', async({pa
expect(htmlReq.headers['foo']).toBe(undefined);
expect(cssReq.headers['foo']).toBe('bar');
});
it('should work with lazy loading iframes', async({page, server}) => {
await page.goto(server.PREFIX + '/frames/lazy-frame.html');
expect(page.frames().length).toBe(2);
});