yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

browser(firefox): ensure rendering update before taking quads and scrolling (#2123)

Browse Source
This commit is contained in:
Dmitry Gozman 2020-05-06 10:20:18 -07:00 committed by GitHub
parent 41de5bc388
commit 10cca041fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browser_patches/firefox/BUILD_NUMBER
View File

@ -1 +1 @@
1089
1090

8
browser_patches/firefox/patches/bootstrap.diff
View File

@ -3639,10 +3639,10 @@ index 0000000000000000000000000000000000000000..155d0770ddf704728829272a41a31ce8
+
diff --git a/juggler/content/PageAgent.js b/juggler/content/PageAgent.js
new file mode 100644
index 0000000000000000000000000000000000000000..63754937b3464794227fe894b3d6057fbf0ae582
index 0000000000000000000000000000000000000000..2d70debb89be35dd68851c47bbee909495808f0b
--- /dev/null
+++ b/juggler/content/PageAgent.js
@@ -0,0 +1,914 @@
@@ -0,0 +1,918 @@
+"use strict";
+const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
+const Ci = Components.interfaces;
@ -4212,6 +4212,8 @@ index 0000000000000000000000000000000000000000..63754937b3464794227fe894b3d6057f
+ const unsafeObject = this._frameData.get(frame).unsafeObject(objectId);
+ if (!unsafeObject.getBoxQuads)
+ throw new Error('RemoteObject is not a node');
+ frame.domWindow().windowUtils.advanceTimeAndRefresh(0);
+ frame.domWindow().windowUtils.restoreNormalRefresh();
+ const quads = unsafeObject.getBoxQuads({relativeTo: this._frameTree.mainFrame().domWindow().document}).map(quad => {
+ return {
+ p1: {x: quad.p1.x, y: quad.p1.y},
@ -4254,6 +4256,8 @@ index 0000000000000000000000000000000000000000..63754937b3464794227fe894b3d6057f
+ throw new Error('Node is detached from document');
+ if (!rect)
+ rect = { x: -1, y: -1, width: -1, height: -1};
+ frame.domWindow().windowUtils.advanceTimeAndRefresh(0);
+ frame.domWindow().windowUtils.restoreNormalRefresh();
+ if (unsafeObject.scrollRectIntoViewIfNeeded)
+ unsafeObject.scrollRectIntoViewIfNeeded(rect.x, rect.y, rect.width, rect.height);
+ else