yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(click): timing out in page while waiting for interactable should have proper error (#1199)

Browse Source 
This fixes flaky 'Page.click should timeout waiting for visible' test.
This commit is contained in:
Dmitry Gozman 2020-03-03 17:14:00 -08:00 committed by GitHub
parent 23790f749d
commit 15c70c9d61
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/injected/injected.ts
View File

@ -366,7 +366,7 @@ class Injected {
throw new Error('Not a checkbox');
}
waitForDisplayedAtStablePosition(node: Node, timeout: number) {
async waitForDisplayedAtStablePosition(node: Node, timeout: number) {
if (!node.isConnected)
throw new Error('Element is not attached to the DOM');
const element = node.nodeType === Node.ELEMENT_NODE ? (node as Element) : node.parentElement;
@ -375,7 +375,7 @@ class Injected {
let lastRect: types.Rect | undefined;
let counter = 0;
return this.poll('raf', undefined, timeout, () => {
const result = await this.poll('raf', undefined, timeout, () => {
// First raf happens in the same animation frame as evaluation, so it does not produce
// any client rect difference compared to synchronous call. We skip the synchronous call
// and only force layout during actual rafs as a small optimisation.
@ -387,18 +387,22 @@ class Injected {
lastRect = rect;
return isDisplayedAndStable;
});
if (!result)
throw new Error(`waiting for element to be displayed and not moving failed: timeout ${timeout}ms exceeded`);
}
waitForHitTargetAt(node: Node, timeout: number, point: types.Point) {
async waitForHitTargetAt(node: Node, timeout: number, point: types.Point) {
const element = node.nodeType === Node.ELEMENT_NODE ? (node as Element) : node.parentElement;
if (!element)
throw new Error('Element is not attached to the DOM');
return this.poll('raf', undefined, timeout, () => {
const result = await this.poll('raf', undefined, timeout, () => {
let hitElement = this.utils.deepElementFromPoint(document, point.x, point.y);
while (hitElement && hitElement !== element)
hitElement = this.utils.parentElementOrShadowHost(hitElement);
return hitElement === element;
});
if (!result)
throw new Error(`waiting for element to receive mouse events failed: timeout ${timeout}ms exceeded`);
}
}