From 16d98cb48a00bfcc25e1662ff9c01d2fd2f03a4d Mon Sep 17 00:00:00 2001
From: Yury Semikhatsky <yurys@chromium.org>
Date: Wed, 31 Mar 2021 12:17:16 -0700
Subject: [PATCH] chore(launcher): add more logging to processKill (#6025)

---
 src/server/processLauncher.ts | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/server/processLauncher.ts b/src/server/processLauncher.ts
index c05a60d95d..6262b6194d 100644
--- a/src/server/processLauncher.ts
+++ b/src/server/processLauncher.ts
@@ -161,15 +161,21 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun
     options.log(`[pid=${spawnedProcess.pid}] <kill>`);
     helper.removeEventListeners(listeners);
     if (spawnedProcess.pid && !spawnedProcess.killed && !processClosed) {
+      options.log(`[pid=${spawnedProcess.pid}] <will force kill>`);
       // Force kill the browser.
       try {
-        if (process.platform === 'win32')
-          childProcess.execSync(`taskkill /pid ${spawnedProcess.pid} /T /F`, { stdio: 'ignore' });
-        else
+        if (process.platform === 'win32') {
+          const stdout = childProcess.execSync(`taskkill /pid ${spawnedProcess.pid} /T /F`);
+          options.log(`[pid=${spawnedProcess.pid}] taskkill output: ${stdout.toString()}`);
+        } else {
           process.kill(-spawnedProcess.pid, 'SIGKILL');
+        }
       } catch (e) {
+        options.log(`[pid=${spawnedProcess.pid}] exception while trying to kill process: ${e}`);
         // the process might have already stopped
       }
+    } else {
+      options.log(`[pid=${spawnedProcess.pid}] <skipped force kill spawnedProcess.killed=${spawnedProcess.killed} processClosed=${processClosed}>`);
     }
     cleanup();
   }