yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(inspector): disable highlight during screenshot actions (#18621)

Browse Source 
Fixes #18049.
This commit is contained in:
Dmitry Gozman 2022-11-07 13:53:15 -08:00 committed by GitHub
parent 9172a2ca5a
commit 1cee65722b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
packages/playwright-core/src/server/recorder.ts
View File

@ -151,12 +151,16 @@ export class Recorder implements InstrumentationListener {
}); });
await this._context.exposeBinding('__pw_recorderState', false, source => { await this._context.exposeBinding('__pw_recorderState', false, source => {
let actionSelector = this._highlightedSelector; let actionSelector = '';
let actionPoint: Point | undefined; let actionPoint: Point | undefined;
for (const [metadata, sdkObject] of this._currentCallsMetadata) { const hasActiveScreenshotCommand = [...this._currentCallsMetadata.keys()].some(isScreenshotCommand);
if (source.page === sdkObject.attribution.page) { if (!hasActiveScreenshotCommand) {
actionPoint = metadata.point || actionPoint; actionSelector = this._highlightedSelector;
actionSelector = actionSelector || metadata.params.selector; for (const [metadata, sdkObject] of this._currentCallsMetadata) {
if (source.page === sdkObject.attribution.page) {
actionPoint = metadata.point || actionPoint;
actionSelector = actionSelector || metadata.params.selector;
}
} }
} }
const uiState: UIState = { const uiState: UIState = {
@ -235,7 +239,9 @@ export class Recorder implements InstrumentationListener {
this._currentCallsMetadata.set(metadata, sdkObject); this._currentCallsMetadata.set(metadata, sdkObject);
this._updateUserSources(); this._updateUserSources();
this.updateCallLog([metadata]); this.updateCallLog([metadata]);
if (metadata.params && metadata.params.selector) { if (isScreenshotCommand(metadata)) {
this.hideHighlightedSelecor();
} else if (metadata.params && metadata.params.selector) {
this._highlightedSelector = metadata.params.selector; this._highlightedSelector = metadata.params.selector;
this._recorderApp?.setSelector(this._highlightedSelector).catch(() => {}); this._recorderApp?.setSelector(this._highlightedSelector).catch(() => {});
} }
@ -675,3 +681,7 @@ class ThrottledFile {
this._text = undefined; this._text = undefined;
} }
} }
function isScreenshotCommand(metadata: CallMetadata) {
return metadata.method.includes('screenshot');
}