yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: have a socket timeout when downloading browsers (#17187)

Browse Source
This commit is contained in:
Max Schmitt 2022-09-08 14:40:41 +02:00 committed by GitHub
parent 22c092db10
commit 1e517731ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/playwright-core/src/server/registry/download.ts
View File

@ -45,6 +45,7 @@ function downloadFile(url: string, destinationPath: string, options: DownloadFil
headers: options.userAgent ? { headers: options.userAgent ? {
'User-Agent': options.userAgent, 'User-Agent': options.userAgent,
} : undefined, } : undefined,
timeout: 10_000,
}, response => { }, response => {
log(`-- response status code: ${response.statusCode}`); log(`-- response status code: ${response.statusCode}`);
if (response.statusCode !== 200) { if (response.statusCode !== 200) {

30
tests/installation/playwright-cdn-should-race-with-timeout.spec.ts Normal file
View File

@ -0,0 +1,30 @@
/**
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import http from 'http';
import type { AddressInfo } from 'net';
import { test, expect } from './npmTest';
test(`playwright cdn should race with a timeout`, async ({ exec }) => {
test.slow(); // This test will timeout on all the 3 fallback CDNs -> 30 seconds duration.
const server = http.createServer(() => {});
await new Promise<void>(resolve => server.listen(0, resolve));
try {
const result = await exec('npm i --foreground-scripts playwright', { env: { PLAYWRIGHT_DOWNLOAD_HOST: `http://127.0.0.1:${(server.address() as AddressInfo).port}`, DEBUG: 'pw:install' }, expectToExitWithError: true });
expect(result).toContain(`timed out after 10000ms`);
} finally {
await new Promise(resolve => server.close(resolve));
}
});