From 20e2bac857d6cd4a4ead75c5983669c1286896ed Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Tue, 11 Feb 2020 15:19:43 -0800 Subject: [PATCH] test: fix flaky page event test --- test/launcher.spec.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/launcher.spec.js b/test/launcher.spec.js index 5b604d5f86..b097b427f3 100644 --- a/test/launcher.spec.js +++ b/test/launcher.spec.js @@ -177,12 +177,12 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p const remote = await playwright.connect({ wsEndpoint: browserServer.wsEndpoint() }); const context = await remote.newContext(); const page = await context.newPage(); - let contextClosed = false; let pageClosed = false; - context.on('close', e => contextClosed = true); page.on('close', e => pageClosed = true); - await browserServer.close(); - expect(contextClosed).toBeTruthy(); + await Promise.all([ + new Promise(f => context.on('close', f)), + browserServer.close() + ]); expect(pageClosed).toBeTruthy(); }); });