yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(snapshots): --update-snapshots + retries should work (#9799)

Browse Source
This commit is contained in:
Dmitry Gozman 2021-10-26 13:50:16 -07:00 committed by GitHub
parent 273122b761
commit 22e4a0d580
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/playwright-test/src/matchers/toMatchSnapshot.ts
View File

@ -45,12 +45,15 @@ export function toMatchSnapshot(this: ReturnType<Expect['getState']>, received:
// sanitizes path if string
const pathSegments = Array.isArray(options.name) ? options.name : [addSuffixToFilePath(options.name, '', undefined, true)];
const withNegateComparison = this.isNot;
let updateSnapshots = testInfo.config.updateSnapshots;
if (updateSnapshots === 'missing' && testInfo.retry < testInfo.project.retries)
updateSnapshots = 'none';
const { pass, message, expectedPath, actualPath, diffPath, mimeType } = compare(
received,
pathSegments,
testInfo.snapshotPath,
testInfo.outputPath,
testInfo.retry < testInfo.project.retries ? 'none' : testInfo.config.updateSnapshots,
updateSnapshots,
withNegateComparison,
options
);

22
tests/playwright-test/golden.spec.ts
View File

@ -655,6 +655,28 @@ test('should fail with missing expectations and retries', async ({ runInlineTest
expect(data.toString()).toBe('Hello world');
});
test('should update expectations with retries', async ({ runInlineTest }, testInfo) => {
const result = await runInlineTest({
...files,
'playwright.config.ts': `
module.exports = { retries: 1 };
`,
'a.spec.js': `
const { test } = require('./helper');
test('is a test', ({}) => {
expect('Hello world').toMatchSnapshot('snapshot.txt');
});
`
}, { 'update-snapshots': true });
expect(result.exitCode).toBe(0);
expect(result.passed).toBe(1);
const snapshotOutputPath = testInfo.outputPath('a.spec.js-snapshots/snapshot.txt');
expect(result.output).toContain(`${snapshotOutputPath} is missing in snapshots, writing actual`);
const data = fs.readFileSync(snapshotOutputPath);
expect(data.toString()).toBe('Hello world');
});
test('should allow comparing text with text without file extension', async ({ runInlineTest }) => {
const result = await runInlineTest({
...files,