yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: unflake browsertype-connect.spec (#11994)

Browse Source 
Consider the scenario:
- First test starts a remote server, connects to it and does not close.
- Remote server fixture stops the server in teardown. Meanwhile,
  the connected browser did not get notified about disconnect just yet.
- Second test starts and sets up tracing in the old connected browser.
- Tracing fails because the browser now realises it has disconnected.
This commit is contained in:
Dmitry Gozman 2022-02-09 17:00:33 -08:00 committed by GitHub
parent 1f6b84f445
commit 284f76357f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/config/browserTest.ts
View File

@ -97,8 +97,12 @@ const test = baseTest.extend<BrowserTestTestFixtures, BrowserTestWorkerFixtures>
await remoteServer._start(childProcess, browserType, options); await remoteServer._start(childProcess, browserType, options);
return remoteServer; return remoteServer;
}); });
if (remoteServer) if (remoteServer) {
await remoteServer.close(); await remoteServer.close();
// Give any connected browsers a chance to disconnect to avoid
// poisoning next test with quasy-alive browsers.
await new Promise(f => setTimeout(f, 1000));
}
}, },
}); });