yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(chromium): ensure we resume service worker before detaching from it (#850)

Browse Source
This commit is contained in:
Dmitry Gozman 2020-02-05 16:08:28 -08:00 committed by GitHub
parent a4c40fff82
commit 28c4a1697c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/chromium/crPage.ts
View File

@ -218,9 +218,10 @@ export class CRPage implements PageDelegate {
_onAttachedToTarget(event: Protocol.Target.attachedToTargetPayload) { _onAttachedToTarget(event: Protocol.Target.attachedToTargetPayload) {
const session = CRConnection.fromSession(this._client).session(event.sessionId)!; const session = CRConnection.fromSession(this._client).session(event.sessionId)!;
if (event.targetInfo.type !== 'worker') { if (event.targetInfo.type !== 'worker') {
// Ideally, detaching should resume any target, but there is bug in the backend. // Ideally, detaching should resume any target, but there is a bug in the backend.
session.send('Runtime.runIfWaitingForDebugger').catch(debugError); session.send('Runtime.runIfWaitingForDebugger').catch(debugError).then(() => {
this._client.send('Target.detachFromTarget', { sessionId: event.sessionId }).catch(debugError); this._client.send('Target.detachFromTarget', { sessionId: event.sessionId }).catch(debugError);
});
return; return;
} }
const url = event.targetInfo.url; const url = event.targetInfo.url;