yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: avoid protocol calls on disposed context (#16812)

Browse Source 
Otherwise, we always get a failing protocol message when closing a context.
This commit is contained in:
Dmitry Gozman 2022-08-24 17:21:01 -07:00 committed by GitHub
parent 553ecce4f9
commit 2c1723b6f5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
View File

@ -227,6 +227,8 @@ export class BrowserContextDispatcher extends Dispatcher<BrowserContext, channel
override _dispose() { override _dispose() {
super._dispose(); super._dispose();
this._context.setRequestInterceptor(undefined).catch(() => {}); // Avoid protocol calls for the closed context.
if (!this._context.isClosingOrClosed())
this._context.setRequestInterceptor(undefined).catch(() => {});
} }
} }