yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: mark waitForNavigation as deprecated consistently (#21309)

Browse Source
This commit is contained in:
Pavel Feldman 2023-03-01 12:40:50 -08:00 committed by GitHub
parent 54dfe5378d
commit 2cbafd7adf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/src/api/class-frame.md
View File

@ -1937,6 +1937,7 @@ await frame.WaitForLoadStateAsync(); // Defaults to LoadState.Load
## async method: Frame.waitForNavigation ## async method: Frame.waitForNavigation
* since: v1.8 * since: v1.8
* deprecated: This method is inherently racy, please use [`method: Frame.waitForURL`] instead.
* langs: * langs:
* alias-python: expect_navigation * alias-python: expect_navigation
* alias-csharp: RunAndWaitForNavigation * alias-csharp: RunAndWaitForNavigation
@ -1995,6 +1996,7 @@ a navigation.
## async method: Frame.waitForNavigation ## async method: Frame.waitForNavigation
* since: v1.8 * since: v1.8
* deprecated: This method is inherently racy, please use [`method: Frame.waitForURL`] instead.
* langs: python * langs: python
- returns: <[EventContextManager]<[Response]>> - returns: <[EventContextManager]<[Response]>>

1
docs/src/api/class-page.md
View File

@ -4249,6 +4249,7 @@ a navigation.
## async method: Page.waitForNavigation ## async method: Page.waitForNavigation
* since: v1.8 * since: v1.8
* deprecated: This method is inherently racy, please use [`method: Page.waitForURL`] instead.
* langs: python * langs: python
- returns: <[EventContextManager]<[Response]>> - returns: <[EventContextManager]<[Response]>>

2
packages/playwright-core/types/types.d.ts vendored
View File

@ -7163,6 +7163,8 @@ export interface Frame {
* *
* **NOTE** Usage of the [History API](https://developer.mozilla.org/en-US/docs/Web/API/History_API) to change the URL * **NOTE** Usage of the [History API](https://developer.mozilla.org/en-US/docs/Web/API/History_API) to change the URL
* is considered a navigation. * is considered a navigation.
* @deprecated This method is inherently racy, please use
* [frame.waitForURL(url[, options])](https://playwright.dev/docs/api/class-frame#frame-wait-for-url) instead.
* @param options * @param options
*/ */
waitForNavigation(options?: { waitForNavigation(options?: {