yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(electron): automatically disable electron sandbox when run as root (#3747)

Browse Source
This commit is contained in:
Andrey Lushnikov 2020-09-02 17:30:10 -07:00 committed by GitHub
parent 0976732ec6
commit 2d46cd8105
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/server/electron/electron.ts
View File

@ -15,6 +15,7 @@
*/
import * as path from 'path';
import * as os from 'os';
import { CRBrowser, CRBrowserContext } from '../chromium/crBrowser';
import { CRConnection, CRSession } from '../chromium/crConnection';
import { CRExecutionContext } from '../chromium/crExecutionContext';
@ -149,6 +150,15 @@ export class Electron {
return runAbortableTask(async progress => {
let app: ElectronApplication | undefined = undefined;
const electronArguments = ['--inspect=0', '--remote-debugging-port=0', '--require', path.join(__dirname, 'electronLoader.js'), ...args];
if (os.platform() === 'linux') {
const runningAsRoot = process.geteuid && process.geteuid() === 0;
if (runningAsRoot && electronArguments.indexOf('--no-sandbox') === -1) {
console.warn('WARNING: Playwright is being run under "root" user - disabling Electron sandbox! Run under regular user to get rid of this warning.');
electronArguments.push('--no-sandbox');
}
}
const { launchedProcess, gracefullyClose, kill } = await launchProcess({
executablePath,
args: electronArguments,