diff --git a/src/server/browser.ts b/src/server/browser.ts index e0a991b5ee..b05919d503 100644 --- a/src/server/browser.ts +++ b/src/server/browser.ts @@ -24,7 +24,6 @@ import { RecentLogsCollector } from '../utils/debugLogger'; import * as registry from '../utils/registry'; import { SdkObject } from './instrumentation'; import { Artifact } from './artifact'; -import { kBrowserClosedError } from '../utils/errors'; export interface BrowserProcess { onclose?: ((exitCode: number | null, signal: string | null) => void); @@ -120,9 +119,6 @@ export abstract class Browser extends SdkObject { context._browserClosed(); if (this._defaultContext) this._defaultContext._browserClosed(); - for (const video of this._idToVideo.values()) - video.artifact.reportFinished(kBrowserClosedError); - this._idToVideo.clear(); this.emit(Browser.Events.Disconnected); } diff --git a/src/server/firefox/ffBrowser.ts b/src/server/firefox/ffBrowser.ts index bf12f0f644..064c6ea404 100644 --- a/src/server/firefox/ffBrowser.ts +++ b/src/server/firefox/ffBrowser.ts @@ -15,6 +15,7 @@ * limitations under the License. */ +import { kBrowserClosedError } from '../../utils/errors'; import { assert } from '../../utils/utils'; import { Browser, BrowserOptions } from '../browser'; import { assertBrowserContextIsNotOwned, BrowserContext, validateBrowserContextOptions, verifyGeolocation } from '../browserContext'; @@ -56,7 +57,7 @@ export class FFBrowser extends Browser { this._connection = connection; this._ffPages = new Map(); this._contexts = new Map(); - this._connection.on(ConnectionEvents.Disconnected, () => this._didClose()); + this._connection.on(ConnectionEvents.Disconnected, () => this._onDisconnect()); this._connection.on('Browser.attachedToTarget', this._onAttachedToTarget.bind(this)); this._connection.on('Browser.detachedFromTarget', this._onDetachedFromTarget.bind(this)); this._connection.on('Browser.downloadCreated', this._onDownloadCreated.bind(this)); @@ -136,6 +137,13 @@ export class FFBrowser extends Browser { _onVideoRecordingFinished(payload: Protocol.Browser.videoRecordingFinishedPayload) { this._takeVideo(payload.screencastId)?.reportFinished(); } + + _onDisconnect() { + for (const video of this._idToVideo.values()) + video.artifact.reportFinished(kBrowserClosedError); + this._idToVideo.clear(); + this._didClose(); + } } export class FFBrowserContext extends BrowserContext { diff --git a/src/server/webkit/wkBrowser.ts b/src/server/webkit/wkBrowser.ts index 1a492bf8e0..429d24d2f8 100644 --- a/src/server/webkit/wkBrowser.ts +++ b/src/server/webkit/wkBrowser.ts @@ -26,6 +26,7 @@ import * as types from '../types'; import { Protocol } from './protocol'; import { kPageProxyMessageReceived, PageProxyMessageReceivedPayload, WKConnection, WKSession } from './wkConnection'; import { WKPage } from './wkPage'; +import { kBrowserClosedError } from '../../utils/errors'; const DEFAULT_USER_AGENT = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.2 Safari/605.1.15'; const BROWSER_VERSION = '14.2'; @@ -72,6 +73,9 @@ export class WKBrowser extends Browser { _onDisconnect() { for (const wkPage of this._wkPages.values()) wkPage.dispose(true); + for (const video of this._idToVideo.values()) + video.artifact.reportFinished(kBrowserClosedError); + this._idToVideo.clear(); this._didClose(); }