yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: do not build docker image for installation tests (#20871)

Browse Source 
This used to be needed to test docker integration and is not needed
any more.
This commit is contained in:
Andrey Lushnikov 2023-02-13 12:31:38 -08:00 committed by GitHub
parent 6d03211439
commit 31460f7ad6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/installation/globalSetup.ts
View File

@ -21,7 +21,6 @@ import fs from 'fs';
import { TMP_WORKSPACES } from './npmTest'; import { TMP_WORKSPACES } from './npmTest';
const PACKAGE_BUILDER_SCRIPT = path.join(__dirname, '..', '..', 'utils', 'pack_package.js'); const PACKAGE_BUILDER_SCRIPT = path.join(__dirname, '..', '..', 'utils', 'pack_package.js');
const DOCKER_BUILDER_SCRIPT = path.join(__dirname, '..', '..', 'utils', 'docker', 'build.sh');
async function globalSetup() { async function globalSetup() {
await promisify(rimraf)(TMP_WORKSPACES); await promisify(rimraf)(TMP_WORKSPACES);
@ -56,20 +55,6 @@ async function globalSetup() {
await fs.promises.writeFile(path.join(__dirname, '.registry.json'), JSON.stringify(Object.fromEntries(builds))); await fs.promises.writeFile(path.join(__dirname, '.registry.json'), JSON.stringify(Object.fromEntries(builds)));
} }
if (process.env.CI && process.platform !== 'linux') {
console.log('Skipped building docker: docker tests are not supported on Windows and macOS Github Actions.');
} else if (process.env.PWTEST_INSTALLATION_TEST_SKIP_DOCKER_BUILD) {
console.log('Skipped building docker. Unset PWTEST_INSTALLATION_TEST_SKIP_DOCKER_BUILD to build docker.');
} else {
console.log('Building docker. Set PWTEST_INSTALLATION_TEST_SKIP_DOCKER_BUILD to skip.');
const DOCKER_IMAGE_NAME = 'playwright:installation-tests-focal';
const arch = process.arch === 'arm64' ? '--arm64' : '--amd64';
const { code, stderr, stdout } = await spawnAsync('bash', [DOCKER_BUILDER_SCRIPT, arch, 'focal', DOCKER_IMAGE_NAME]);
if (!!code)
throw new Error(`Failed to build docker:\n${stderr}\n${stdout}`);
console.log('Built: docker image ', DOCKER_IMAGE_NAME);
}
} }
export default globalSetup; export default globalSetup;