yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: remove test which is inherently racy (#1313)

Browse Source 
page.evaluate() sometimes triggers navigation fast enoguh, so that
next page.setContent() has no execution context to evaluate in.
This commit is contained in:
Dmitry Gozman 2020-03-10 10:11:44 -07:00 committed by GitHub
parent d5a2781e80
commit 38c3837b3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/page.spec.js
View File

@ -511,27 +511,6 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF
const result = await page.content(); const result = await page.content();
expect(result).toBe(expectedOutput); expect(result).toBe(expectedOutput);
}); });
it.fail(true)('should not confuse with previous navigation', async({page, server}) => {
const imgPath = '/img.png';
let imgResponse = null;
server.setRoute(imgPath, (req, res) => imgResponse = res);
let loaded = false;
// get the global object to make sure that the main execution context is alive and well.
await page.evaluate(() => this);
// Trigger navigation which might resolve next setContent call.
const evalPromise = page.evaluate(url => window.location.href = url, server.EMPTY_PAGE);
const contentPromise = page.setContent(`<img src="${server.PREFIX + imgPath}"></img>`).then(() => loaded = true);
await server.waitForRequest(imgPath);
expect(loaded).toBe(false);
for (let i = 0; i < 5; i++)
await page.evaluate('1'); // Roundtrips to give setContent a chance to resolve.
expect(loaded).toBe(false);
imgResponse.end();
await contentPromise;
await evalPromise;
});
it('should work with doctype', async({page, server}) => { it('should work with doctype', async({page, server}) => {
const doctype = '<!DOCTYPE html>'; const doctype = '<!DOCTYPE html>';
await page.setContent(`${doctype}<div>hello</div>`); await page.setContent(`${doctype}<div>hello</div>`);