yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test runner): perform shallow clone check in config directory (#32299)

Browse Source 
Our CI operates on shallow clones. In vcs.ts, we perform a check for
shallow clones in `process.cwd()` instead of the test directory. This
makes the test in
3c208aeeff/tests/playwright-test/only-changed.spec.ts (L201)
failing in CI, but only for PRs. The fix is to perform the check on. the
test directory.
This commit is contained in:
Simon Knott 2024-09-02 09:11:04 +02:00 committed by GitHub
parent cf8c14f884
commit 3f09d10601
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright/src/runner/vcs.ts
View File

@ -30,7 +30,7 @@ export async function detectChangedTestFiles(baseCommit: string, configDir: stri
const unknownRevision = error.output.some(line => line?.includes('unknown revision')); const unknownRevision = error.output.some(line => line?.includes('unknown revision'));
if (unknownRevision) { if (unknownRevision) {
const isShallowClone = childProcess.execSync('git rev-parse --is-shallow-repository', { encoding: 'utf-8', stdio: 'pipe' }).trim() === 'true'; const isShallowClone = childProcess.execSync('git rev-parse --is-shallow-repository', { encoding: 'utf-8', stdio: 'pipe', cwd: configDir }).trim() === 'true';
if (isShallowClone) { if (isShallowClone) {
throw new Error([ throw new Error([
`The repository is a shallow clone and does not have '${baseCommit}' available locally.`, `The repository is a shallow clone and does not have '${baseCommit}' available locally.`,