yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(vrt): bring back wait for font loading (#28226)

Browse Source
This commit is contained in:
Pavel Feldman 2023-11-17 17:16:32 -08:00 committed by GitHub
parent 34c8516d09
commit 3f55587dd8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/playwright-core/src/server/screenshotter.ts
View File

@ -240,6 +240,13 @@ export class Screenshotter {
await Promise.all(this._page.frames().map(async frame => { await Promise.all(this._page.frames().map(async frame => {
await frame.nonStallingEvaluateInExistingContext('(' + inPagePrepareForScreenshots.toString() + `)(${hideCaret}, ${disableAnimations})`, false, 'utility').catch(() => {}); await frame.nonStallingEvaluateInExistingContext('(' + inPagePrepareForScreenshots.toString() + `)(${hideCaret}, ${disableAnimations})`, false, 'utility').catch(() => {});
})); }));
if (!process.env.PW_TEST_SCREENSHOT_NO_FONTS_READY) {
progress.log('waiting for fonts to load...');
await Promise.all(this._page.frames().map(async frame => {
await frame.nonStallingEvaluateInExistingContext('document.fonts.ready', false, 'utility').catch(() => {});
}));
progress.log('fonts loaded');
}
progress.cleanupWhenAborted(() => this._restorePageAfterScreenshot()); progress.cleanupWhenAborted(() => this._restorePageAfterScreenshot());
} }

26
tests/page/page-screenshot.spec.ts
View File

@ -824,6 +824,32 @@ it.describe('page screenshot animations', () => {
'onfinish', 'animationend' 'onfinish', 'animationend'
]); ]);
}); });
it('should wait for fonts to load', async ({ page, server, isWindows, browserName, isLinux }) => {
it.fixme(isWindows, 'This requires a windows-specific test expectations. https://github.com/microsoft/playwright/issues/12707');
await page.setViewportSize({ width: 500, height: 500 });
const fontRequestPromise = new Promise<any>(resolve => {
// Stall font loading.
server.setRoute('/webfont/iconfont.woff2', (request, response) => {
resolve({ request, response });
});
});
await page.goto(server.PREFIX + '/webfont/webfont.html', {
waitUntil: 'domcontentloaded', // 'load' will not happen if webfont is pending
});
// Make sure screenshot times out while webfont is stalled.
const error = await page.screenshot({ timeout: 200, }).catch(e => e);
expect(error.message).toContain('waiting for fonts to load...');
expect(error.message).toContain('Timeout 200ms exceeded');
const fontRequest = await fontRequestPromise;
server.serveFile(fontRequest.request, fontRequest.response);
const iconsScreenshot = await page.screenshot();
expect(iconsScreenshot).toMatchSnapshot('screenshot-web-font.png', {
maxDiffPixels: 50,
});
});
}); });
it('should throw if screenshot size is too large', async ({ page, browserName, isMac }) => { it('should throw if screenshot size is too large', async ({ page, browserName, isMac }) => {