yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(codgen): assertValue works with disabled select (#31315)

Browse Source
This commit is contained in:
4ydx 2024-06-29 05:04:59 +09:00 committed by GitHub
parent ea33137a0e
commit 4089f4593b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/playwright-core/src/server/injected/recorder/recorder.ts
View File

@ -578,8 +578,8 @@ class TextAssertionTool implements RecorderTool {
onPointerUp(event: PointerEvent) { onPointerUp(event: PointerEvent) {
const target = this._hoverHighlight?.elements[0]; const target = this._hoverHighlight?.elements[0];
if (this._kind === 'value' && target && target.nodeName === 'INPUT' && (target as HTMLInputElement).disabled) { if (this._kind === 'value' && target && (target.nodeName === 'INPUT' || target.nodeName === 'SELECT') && (target as HTMLInputElement).disabled) {
// Click on a disabled input does not produce a "click" event, but we still want // Click on a disabled input (or select) does not produce a "click" event, but we still want
// to assert the value. // to assert the value.
this._commitAssertValue(); this._commitAssertValue();
} }

21
tests/library/inspector/cli-codegen-3.spec.ts
View File

@ -631,6 +631,27 @@ await page.GetByLabel("Coun\\"try").ClickAsync();`);
expect.soft(sources2.get('C#')!.text).toContain(`await Expect(page.Locator("#second")).ToHaveValueAsync("bar")`); expect.soft(sources2.get('C#')!.text).toContain(`await Expect(page.Locator("#second")).ToHaveValueAsync("bar")`);
}); });
test('should assert value on disabled select', async ({ openRecorder, browserName }) => {
const recorder = await openRecorder();
await recorder.setContentAndWait(`
<select id=first><option value=foo1>Foo1</option><option value=bar1>Bar1</option></select>
<select id=second disabled><option value=foo2>Foo2</option><option value=bar2 selected>Bar2</option></select>
`);
await recorder.page.click('x-pw-tool-item.value');
await recorder.hoverOverElement('#second');
const [sources2] = await Promise.all([
recorder.waitForOutput('JavaScript', '#second'),
recorder.trustedClick(),
]);
expect.soft(sources2.get('JavaScript')!.text).toContain(`await expect(page.locator('#second')).toHaveValue('bar2')`);
expect.soft(sources2.get('Python')!.text).toContain(`expect(page.locator("#second")).to_have_value("bar2")`);
expect.soft(sources2.get('Python Async')!.text).toContain(`await expect(page.locator("#second")).to_have_value("bar2")`);
expect.soft(sources2.get('Java')!.text).toContain(`assertThat(page.locator("#second")).hasValue("bar2")`);
expect.soft(sources2.get('C#')!.text).toContain(`await Expect(page.Locator("#second")).ToHaveValueAsync("bar2")`);
});
test('should assert visibility', async ({ openRecorder }) => { test('should assert visibility', async ({ openRecorder }) => {
const recorder = await openRecorder(); const recorder = await openRecorder();