yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(install): Improve ECONNRESET handling in downloadFile (#28344)

Browse Source 
See
https://github.com/microsoft/playwright/issues/28329#issuecomment-1826753106
for context
This commit is contained in:
Alexander Kachkaev 2023-11-27 20:44:24 +00:00 committed by GitHub
parent dc8ecc3ca4
commit 41728e7098
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/playwright-core/src/server/registry/oopDownloadBrowserMain.ts
View File

@ -85,12 +85,15 @@ function downloadFile(options: DownloadParams): Promise<void> {
file.on('error', error => promise.reject(error)); file.on('error', error => promise.reject(error));
response.pipe(file); response.pipe(file);
response.on('data', onData); response.on('data', onData);
response.on('close', () => { response.on('error', (error: any) => {
if (response.complete)
return;
file.close(); file.close();
if (error?.code === 'ECONNRESET') {
log(`-- download failed, server closed connection`); log(`-- download failed, server closed connection`);
promise.reject(new Error(`Download failed: server closed connection. URL: ${options.url}`)); promise.reject(new Error(`Download failed: server closed connection. URL: ${options.url}`));
} else {
log(`-- download failed, unexpected error`);
promise.reject(new Error(`Download failed: ${error?.message ?? error}. URL: ${options.url}`));
}
}); });
}, (error: any) => promise.reject(error)); }, (error: any) => promise.reject(error));
return promise; return promise;