yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui mode): make sure key for attachment view is unique (#32084)

Browse Source 
Fixes #32052.
This commit is contained in:
Dmitry Gozman 2024-08-08 10:57:44 -07:00 committed by GitHub
parent 80e014f4b6
commit 44445e30e5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/trace-viewer/src/ui/attachmentsTab.tsx
View File

@ -131,7 +131,7 @@ export const AttachmentsTab: React.FunctionComponent<{
})} })}
{attachments.size ? <div className='attachments-section'>Attachments</div> : undefined} {attachments.size ? <div className='attachments-section'>Attachments</div> : undefined}
{[...attachments.values()].map((a, i) => { {[...attachments.values()].map((a, i) => {
return <div className='attachment-item' key={`attachment-${i}`}> return <div className='attachment-item' key={attachmentKey(a, i)}>
<ExpandableAttachment attachment={a} /> <ExpandableAttachment attachment={a} />
</div>; </div>;
})} })}
@ -154,3 +154,7 @@ function downloadURL(attachment: Attachment) {
params.dct = attachment.contentType; params.dct = attachment.contentType;
return attachmentURL(attachment, params); return attachmentURL(attachment, params);
} }
function attachmentKey(attachment: Attachment, index: number) {
return index + '-' + (attachment.sha1 ? `sha1-` + attachment.sha1 : `path-` + attachment.path);
}