From 45ee31867327dc8694e37ea643d29e3fa5099bb3 Mon Sep 17 00:00:00 2001
From: Playwright Service <89237858+playwrightmachine@users.noreply.github.com>
Date: Wed, 19 Jun 2024 10:03:58 -0700
Subject: [PATCH] feat(firefox): roll to r1456 (#31375)

Fixes https://github.com/microsoft/playwright/issues/31328
Fixes https://github.com/microsoft/playwright/issues/30837

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
---
 packages/playwright-core/browsers.json | 2 +-
 tests/library/video.spec.ts            | 3 +--
 tests/page/page-emulate-media.spec.ts  | 3 +--
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json
index 6fad0fd03c..6dad66e8fc 100644
--- a/packages/playwright-core/browsers.json
+++ b/packages/playwright-core/browsers.json
@@ -15,7 +15,7 @@
     },
     {
       "name": "firefox",
-      "revision": "1454",
+      "revision": "1456",
       "installByDefault": true,
       "browserVersion": "127.0"
     },
diff --git a/tests/library/video.spec.ts b/tests/library/video.spec.ts
index 5ceae2f04e..39dcaecbc6 100644
--- a/tests/library/video.spec.ts
+++ b/tests/library/video.spec.ts
@@ -206,9 +206,8 @@ it.describe('screencast', () => {
     expectRedFrames(videoFile, size);
   });
 
-  it('should continue recording main page after popup closes', async ({ browser, browserName, trace, headless, isWindows }, testInfo) => {
+  it('should continue recording main page after popup closes', async ({ browser, browserName }, testInfo) => {
     it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/30837' });
-    it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/30837');
     // Firefox does not have a mobile variant and has a large minimum size (500 on windows and 450 elsewhere).
     const size = browserName === 'firefox' ? { width: 500, height: 400 } : { width: 320, height: 240 };
     const context = await browser.newContext({
diff --git a/tests/page/page-emulate-media.spec.ts b/tests/page/page-emulate-media.spec.ts
index d1ba297ae4..c895d64eff 100644
--- a/tests/page/page-emulate-media.spec.ts
+++ b/tests/page/page-emulate-media.spec.ts
@@ -124,9 +124,8 @@ it('should emulate reduced motion', async ({ page }) => {
   await page.emulateMedia({ reducedMotion: null });
 });
 
-it('should keep reduced motion and color emulation after reload', async ({ page, server, browserName }) => {
+it('should keep reduced motion and color emulation after reload', async ({ page, server }) => {
   it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/31328' });
-  it.fixme(browserName === 'firefox');
 
   // Pre-conditions
   expect(await page.evaluate(() => matchMedia('(prefers-reduced-motion: reduce)').matches)).toEqual(false);