yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(logs): restore pw:browser logs after launch has finished (#5527)

Browse Source
This commit is contained in:
Dmitry Gozman 2021-02-19 16:09:38 -08:00 committed by GitHub
parent e2a935b3d6
commit 46c8c29f7a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/server/progress.ts
View File

@ -70,10 +70,10 @@ export class ProgressController {
const progress: Progress = { const progress: Progress = {
log: message => { log: message => {
if (this._state === 'running') { if (this._state === 'running')
this.metadata.log.push(message); this.metadata.log.push(message);
this.instrumentation.onCallLog(this._logName, message, this.sdkObject, this.metadata); // Note: we might be sending logs after progress has finished, for example browser logs.
} this.instrumentation.onCallLog(this._logName, message, this.sdkObject, this.metadata);
}, },
timeUntilDeadline: () => this._deadline ? this._deadline - monotonicTime() : 2147483647, // 2^31-1 safe setTimeout in Node. timeUntilDeadline: () => this._deadline ? this._deadline - monotonicTime() : 2147483647, // 2^31-1 safe setTimeout in Node.
isRunning: () => this._state === 'running', isRunning: () => this._state === 'running',