From 49cb96c433c0b050d53b9be280de0de720155aef Mon Sep 17 00:00:00 2001
From: Yury Semikhatsky <yurys@chromium.org>
Date: Thu, 11 Jun 2020 23:58:24 -0700
Subject: [PATCH] devops: enable core dumps in the subshell (#2555)

---
 .github/workflows/tests.yml | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 5852c3ab12..3e8b2e407c 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -26,14 +26,13 @@ jobs:
         node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - run: npm ci
-    # Enable core dumps in this terminal.
-    - run: ulimit -c unlimited
     - run: mkdir -p coredumps
     # Set core dump file name pattern
     - run: sudo bash -c 'echo "$(pwd -P)/coredumps/core-pid_%p.dump" > /proc/sys/kernel/core_pattern'
     # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
     # Wrap `npm run` in a subshell to redirect STDERR to file.
-    - run: xvfb-run --auto-servernum -- bash -c "npm run ccoverage 2>./chromium-linux-testrun.log"
+    # Enable core dumps in the subshell.
+    - run: xvfb-run --auto-servernum -- bash -c "ulimit -c unlimited && npm run ccoverage 2>./chromium-linux-testrun.log"
       env:
         DEBUG: "*"
     # Ensure output folder exists just in case it was not created by the test run.
@@ -52,7 +51,7 @@ jobs:
     - uses: actions/upload-artifact@v1
       if: failure()
       with:
-        name: coredumps
+        name: chromium-linux-coredumps
         path: coredumps
 
   chromium_mac:
@@ -120,14 +119,13 @@ jobs:
         node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - run: npm ci
-    # Enable core dumps in this terminal.
-    - run: ulimit -c unlimited
     - run: mkdir -p coredumps
     # Set core dump file name pattern
     - run: sudo bash -c 'echo "$(pwd -P)/coredumps/core-pid_%p.dump" > /proc/sys/kernel/core_pattern'
     # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
     # Wrap `npm run` in a subshell to redirect STDERR to file.
-    - run: xvfb-run --auto-servernum -- bash -c "npm run wcoverage 2>./webkit-linux-testrun.log"
+    # Enable core dumps in the subshell.
+    - run: xvfb-run --auto-servernum -- bash -c "ulimit -c unlimited && npm run wcoverage 2>./webkit-linux-testrun.log"
       env:
         DEBUG: "*,-pw:wrapped*"
     # Ensure output folder exists just in case it was not created by the test run.
@@ -146,7 +144,7 @@ jobs:
     - uses: actions/upload-artifact@v1
       if: failure()
       with:
-        name: coredumps
+        name: webkit-linux-coredumps
         path: coredumps
 
   webkit_mac:
@@ -214,14 +212,13 @@ jobs:
         node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - run: npm ci
-    # Enable core dumps in this terminal.
-    - run: ulimit -c unlimited
     - run: mkdir -p coredumps
     # Set core dump file name pattern
     - run: sudo bash -c 'echo "$(pwd -P)/coredumps/core-pid_%p.dump" > /proc/sys/kernel/core_pattern'
     # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
     # Wrap `npm run` in a subshell to redirect STDERR to file.
-    - run: xvfb-run --auto-servernum -- bash -c "npm run fcoverage 2>./firefox-linux-testrun.log"
+    # Enable core dumps in the subshell.
+    - run: xvfb-run --auto-servernum -- bash -c "ulimit -c unlimited && npm run fcoverage 2>./firefox-linux-testrun.log"
       env:
         DEBUG: "*"
     # Ensure output folder exists just in case it was not created by the test run.
@@ -240,7 +237,7 @@ jobs:
     - uses: actions/upload-artifact@v1
       if: failure()
       with:
-        name: coredumps
+        name: firefox-linux-coredumps
         path: coredumps
 
   firefox_mac: