From 51a8807f6bad41dd5316775ce859a5009da4c21b Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Fri, 7 Oct 2022 06:55:26 -0700 Subject: [PATCH] chore: make local docker build work on branch (#17896) Branch does not pass `isDevelopmentMode` check because it does not have a version ending with `-next`. Therefore, `env.PWTEST_DOCKER_BASE_IMAGE` is ignored which leads to the pull of non-existent image. --- packages/playwright-core/src/containers/docker.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/playwright-core/src/containers/docker.ts b/packages/playwright-core/src/containers/docker.ts index d93943c299..f973f93f08 100644 --- a/packages/playwright-core/src/containers/docker.ts +++ b/packages/playwright-core/src/containers/docker.ts @@ -76,7 +76,7 @@ async function buildPlaywrightImage() { await checkDockerEngineIsRunningOrDie(); const isDevelopmentMode = getPlaywrightVersion().includes('next'); - let baseImageName = `mcr.microsoft.com/playwright:v${getPlaywrightVersion()}-${VRT_IMAGE_DISTRO}`; + let baseImageName = process.env.PWTEST_DOCKER_BASE_IMAGE || `mcr.microsoft.com/playwright:v${getPlaywrightVersion()}-${VRT_IMAGE_DISTRO}`; // 1. Build or pull base image. if (isDevelopmentMode) { // Use our docker build scripts in development mode!