yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(screencast): always send at least one frame in wpe (#3760)

Browse Source
This commit is contained in:
Yury Semikhatsky 2020-09-03 16:55:54 -07:00 committed by GitHub
parent 190d16daa3
commit 52fd88b13d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browsers.json
View File

@ -13,7 +13,7 @@
}, },
{ {
"name": "webkit", "name": "webkit",
"revision": "1338", "revision": "1339",
"download": true "download": true
} }
] ]

9
test/screencast.spec.ts
View File

@ -173,11 +173,6 @@ describe('screencast', suite => {
const videoFile = path.join(tmpDir, 'v.webm'); const videoFile = path.join(tmpDir, 'v.webm');
await page.evaluate(() => document.body.style.backgroundColor = 'red'); await page.evaluate(() => document.body.style.backgroundColor = 'red');
await toImpl(page)._delegate.startScreencast({outputFile: videoFile, width: 320, height: 240}); await toImpl(page)._delegate.startScreencast({outputFile: videoFile, width: 320, height: 240});
// TODO: in WebKit figure out why video size is not reported correctly for
// static pictures.
if (options.HEADLESS && options.WEBKIT)
await page.setViewportSize({width: 1270, height: 950});
await new Promise(r => setTimeout(r, 1000)); await new Promise(r => setTimeout(r, 1000));
await toImpl(page)._delegate.stopScreencast(); await toImpl(page)._delegate.stopScreencast();
expect(fs.existsSync(videoFile)).toBe(true); expect(fs.existsSync(videoFile)).toBe(true);
@ -202,10 +197,6 @@ describe('screencast', suite => {
const videoFile = path.join(tmpDir, 'v.webm'); const videoFile = path.join(tmpDir, 'v.webm');
await page.goto(server.PREFIX + '/background-color.html#rgb(0,0,0)'); await page.goto(server.PREFIX + '/background-color.html#rgb(0,0,0)');
await toImpl(page)._delegate.startScreencast({outputFile: videoFile, width: 320, height: 240}); await toImpl(page)._delegate.startScreencast({outputFile: videoFile, width: 320, height: 240});
// TODO: in WebKit figure out why video size is not reported correctly for
// static pictures.
if (options.HEADLESS && options.WEBKIT)
await page.setViewportSize({width: 1270, height: 950});
await new Promise(r => setTimeout(r, 1000)); await new Promise(r => setTimeout(r, 1000));
await page.goto(server.CROSS_PROCESS_PREFIX + '/background-color.html#rgb(100,100,100)'); await page.goto(server.CROSS_PROCESS_PREFIX + '/background-color.html#rgb(100,100,100)');
await new Promise(r => setTimeout(r, 1000)); await new Promise(r => setTimeout(r, 1000));