From 52fe02eea601fbed9b1ed6cc9d2ae2e87e00ae2f Mon Sep 17 00:00:00 2001
From: Andrey Lushnikov <aslushnikov@gmail.com>
Date: Tue, 14 Apr 2020 22:40:33 -0700
Subject: [PATCH] devops: enforce strict treatment of unhandled rejections
 (#1789)

Run all our tests with node.js flag `--unhandled-rejections=strict`.
---
 .github/workflows/tests.yml | 18 +++++++++---------
 package.json                | 24 ++++++++++++------------
 2 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 691855b4ee..f167a8985c 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -21,7 +21,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 10.15
+        node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - name: install xvfb
       run: |
@@ -53,7 +53,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 10.15
+        node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - run: npm install
     - run: npm run ctest 2>./chromium-mac-testrun.log
@@ -80,7 +80,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 10.15
+        node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - run: npm install
     - run: npm run ctest 2>./chromium-win-testrun.log
@@ -108,7 +108,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 10.15
+        node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - name: install xvfb
       run: |
@@ -140,7 +140,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 10.15
+        node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - run: npm install
     - run: npm run wtest 2>./webkit-mac-testrun.log
@@ -167,7 +167,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 10.15
+        node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - run: npm install
     - run: npm run wtest 2>./webkit-win-testrun.log
@@ -195,7 +195,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 10.15
+        node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - name: install xvfb
       run: |
@@ -227,7 +227,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 10.15
+        node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - run: npm install
     - run: npm run ftest 2>./firefox-mac-testrun.log
@@ -254,7 +254,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 10.15
+        node-version: 10
     - uses: microsoft/playwright-github-action@v1
     - run: npm install
     - run: npm run ftest 2>./firefox-win-testrun.log
diff --git a/package.json b/package.json
index 0f2371e908..48535a8760 100644
--- a/package.json
+++ b/package.json
@@ -13,18 +13,18 @@
     "webkit_revision": "1193"
   },
   "scripts": {
-    "ctest": "cross-env BROWSER=chromium node test/test.js",
-    "ftest": "cross-env BROWSER=firefox node test/test.js",
-    "wtest": "cross-env BROWSER=webkit node test/test.js",
-    "test": "cross-env BROWSER=all node test/test.js",
-    "cunit": "cross-env BROWSER=chromium node test/test.js",
-    "funit": "cross-env BROWSER=firefox node test/test.js",
-    "wunit": "cross-env BROWSER=webkit node test/test.js",
-    "unit": "cross-env BROWSER=all node test/test.js",
-    "ccoverage": "cross-env COVERAGE=true BROWSER=chromium node test/test.js",
-    "fcoverage": "cross-env COVERAGE=true BROWSER=firefox node test/test.js",
-    "wcoverage": "cross-env COVERAGE=true BROWSER=webkit node test/test.js",
-    "coverage": "cross-env COVERAGE=true BROWSER=all node test/test.js",
+    "ctest": "cross-env BROWSER=chromium node --unhandled-rejections=strict test/test.js",
+    "ftest": "cross-env BROWSER=firefox node --unhandled-rejections=strict test/test.js",
+    "wtest": "cross-env BROWSER=webkit node --unhandled-rejections=strict test/test.js",
+    "test": "cross-env BROWSER=all node --unhandled-rejections=strict test/test.js",
+    "cunit": "cross-env BROWSER=chromium node --unhandled-rejections=strict test/test.js",
+    "funit": "cross-env BROWSER=firefox node --unhandled-rejections=strict test/test.js",
+    "wunit": "cross-env BROWSER=webkit node --unhandled-rejections=strict test/test.js",
+    "unit": "cross-env BROWSER=all node --unhandled-rejections=strict test/test.js",
+    "ccoverage": "cross-env COVERAGE=true BROWSER=chromium node --unhandled-rejections=strict test/test.js",
+    "fcoverage": "cross-env COVERAGE=true BROWSER=firefox node --unhandled-rejections=strict test/test.js",
+    "wcoverage": "cross-env COVERAGE=true BROWSER=webkit node --unhandled-rejections=strict test/test.js",
+    "coverage": "cross-env COVERAGE=true BROWSER=all node --unhandled-rejections=strict test/test.js",
     "eslint": "[ \"$CI\" = true ] && eslint --quiet -f codeframe --ext js,ts ./src || eslint --ext js,ts ./src",
     "tsc": "tsc -p .",
     "doc": "node utils/doclint/cli.js",